Add title to webviewCreate

Part of #44579
This commit is contained in:
Matt Bierner
2018-02-27 15:46:50 -08:00
parent 724217dff1
commit a989220093
6 changed files with 14 additions and 13 deletions

View File

@@ -429,8 +429,8 @@ export class MainThreadWebviews implements MainThreadWebviewsShape {
this._toDispose = dispose(this._toDispose);
}
$createWebview(handle: WebviewHandle, uri: URI, options: vscode.WebviewOptions): void {
const webviewInput = WebviewInput.create(URI.revive(uri), '', options, '', {
$createWebview(handle: WebviewHandle, uri: URI, title: string, column: Position, options: vscode.WebviewOptions): void {
const webviewInput = WebviewInput.create(URI.revive(uri), title, options, '', {
onMessage: message => this._proxy.$onMessage(handle, message),
onDidChangePosition: position => this._proxy.$onDidChangePosition(handle, position),
onDispose: () => this._proxy.$onDidDisposeWeview(handle),
@@ -438,6 +438,8 @@ export class MainThreadWebviews implements MainThreadWebviewsShape {
}, this._partService);
this._webviews.set(handle, webviewInput);
this._editorService.openEditor(webviewInput, { pinned: true }, column);
}
$disposeWebview(handle: WebviewHandle): void {