Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-27 12:04:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

Stop TS From Spamming Crash Messages (#20081)

Browse Source 
* Stop TS From Spamming Crash Messages

**Bug**
When the tsserver crashes repeatedly, it can end up spamming users with constant alerts. This is not too helpful

**Fix**
A number of small fixes:

* Lengthen ts 5 crash timeout to 10 seconds from 2 seconds. 5 crashes in 10 seconds == no attempted restart
* Reset the last started time when we have any number of crashes in the row. This resets the crash windows.
* Fix all crashes after 5 retriggering the same logic. I believe the intent was that we should show these errors every five crashes, not on any crash after the fifth one

* Set last startTime on boot
This commit is contained in:
Matt Bierner
2017-02-07 11:05:04 -08:00
committed by GitHub
parent 1a89bb74c6
commit aa3d327cb7
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/typescript/src/typescriptServiceClient.ts
View File

@@ -129,6 +129,7 @@ export default class TypeScriptServiceClient implements ITypescriptServiceClient
this.storagePath = storagePath;
this.globalState = globalState;
this.pathSeparator = path.sep;
this.lastStart = Date.now();
var p = new Promise<void>((resolve, reject) => {
this._onReady = { promise: p, resolve, reject };
@@ -643,7 +644,9 @@ export default class TypeScriptServiceClient implements ITypescriptServiceClient
let startService = true;
if (this.numberRestarts > 5) {
let prompt: Thenable<MyMessageItem | undefined> | undefined = undefined;
this.numberRestarts = 0;
if (diff < 60 * 1000 /* 1 Minutes */) {
this.lastStart = Date.now();
prompt = window.showWarningMessage<MyMessageItem>(
localize('serverDied', 'The TypeScript language service died unexpectedly 5 times in the last 5 Minutes.'),
{
@@ -651,7 +654,8 @@ export default class TypeScriptServiceClient implements ITypescriptServiceClient
id: MessageAction.reportIssue,
isCloseAffordance: true
});
} else if (diff < 2 * 1000 /* 2 seconds */) {
} else if (diff < 10 * 1000 /* 10 seconds */) {
this.lastStart = Date.now();
startService = false;
prompt = window.showErrorMessage<MyMessageItem>(
localize('serverDiedAfterStart', 'The TypeScript language service died 5 times right after it got started. The service will not be restarted.'),