diff --git a/eslint.config.js b/eslint.config.js index 9d83f9269e3..c54623a4e06 100644 --- a/eslint.config.js +++ b/eslint.config.js @@ -460,7 +460,6 @@ export default tseslint.config( 'src/vs/platform/keybinding/common/keybindingResolver.ts', 'src/vs/platform/keybinding/common/keybindingsRegistry.ts', 'src/vs/platform/keybinding/common/resolvedKeybindingItem.ts', - 'src/vs/platform/keyboardLayout/common/keyboardConfig.ts', 'src/vs/platform/languagePacks/node/languagePacks.ts', 'src/vs/platform/list/browser/listService.ts', 'src/vs/platform/log/browser/log.ts', @@ -524,9 +523,6 @@ export default tseslint.config( 'src/vs/editor/contrib/dropOrPasteInto/browser/dropIntoEditorContribution.ts', 'src/vs/editor/contrib/find/browser/findController.ts', 'src/vs/editor/contrib/find/browser/findModel.ts', - 'src/vs/editor/contrib/find/browser/findWidgetSearchHistory.ts', - 'src/vs/editor/contrib/find/browser/replaceWidgetHistory.ts', - 'src/vs/editor/contrib/folding/browser/folding.ts', 'src/vs/editor/contrib/gotoSymbol/browser/goToCommands.ts', 'src/vs/editor/contrib/gotoSymbol/browser/symbolNavigation.ts', 'src/vs/editor/contrib/hover/browser/hoverActions.ts', @@ -608,7 +604,6 @@ export default tseslint.config( 'src/vs/workbench/contrib/authentication/browser/actions/manageTrustedMcpServersForAccountAction.ts', 'src/vs/workbench/contrib/bulkEdit/browser/bulkCellEdits.ts', 'src/vs/workbench/contrib/bulkEdit/browser/bulkTextEdits.ts', - 'src/vs/workbench/contrib/bulkEdit/browser/opaqueEdits.ts', 'src/vs/workbench/contrib/bulkEdit/browser/preview/bulkEditPane.ts', 'src/vs/workbench/contrib/bulkEdit/browser/preview/bulkEditPreview.ts', 'src/vs/workbench/contrib/chat/browser/actions/chatCodeblockActions.ts', @@ -640,7 +635,6 @@ export default tseslint.config( 'src/vs/workbench/contrib/codeEditor/browser/outline/documentSymbolsOutline.ts', 'src/vs/workbench/contrib/codeEditor/electron-browser/selectionClipboard.ts', 'src/vs/workbench/contrib/commands/common/commands.contribution.ts', - 'src/vs/workbench/contrib/comments/browser/commentNode.ts', 'src/vs/workbench/contrib/comments/browser/commentsAccessibleView.ts', 'src/vs/workbench/contrib/comments/browser/commentsTreeViewer.ts', 'src/vs/workbench/contrib/comments/browser/commentsView.ts', @@ -683,7 +677,6 @@ export default tseslint.config( 'src/vs/workbench/contrib/inlineChat/browser/inlineChatActions.ts', 'src/vs/workbench/contrib/inlineChat/browser/inlineChatController.ts', 'src/vs/workbench/contrib/inlineChat/browser/inlineChatStrategies.ts', - 'src/vs/workbench/contrib/issue/browser/issueReporterModel.ts', 'src/vs/workbench/contrib/markdown/browser/markdownDocumentRenderer.ts', 'src/vs/workbench/contrib/markdown/browser/markdownSettingRenderer.ts', 'src/vs/workbench/contrib/markers/browser/markers.contribution.ts', @@ -716,7 +709,6 @@ export default tseslint.config( 'src/vs/workbench/contrib/notebook/browser/viewParts/notebookEditorStickyScroll.ts', 'src/vs/workbench/contrib/notebook/browser/viewParts/notebookHorizontalTracker.ts', 'src/vs/workbench/contrib/notebook/browser/viewParts/notebookKernelQuickPickStrategy.ts', - 'src/vs/workbench/contrib/notebook/browser/viewParts/notebookViewZones.ts', 'src/vs/workbench/contrib/notebook/common/model/notebookCellTextModel.ts', 'src/vs/workbench/contrib/notebook/common/model/notebookMetadataTextModel.ts', 'src/vs/workbench/contrib/notebook/common/model/notebookTextModel.ts', @@ -725,7 +717,6 @@ export default tseslint.config( 'src/vs/workbench/contrib/notebook/common/notebookRange.ts', 'src/vs/workbench/contrib/notebook/test/browser/testNotebookEditor.ts', 'src/vs/workbench/contrib/performance/electron-browser/startupProfiler.ts', - 'src/vs/workbench/contrib/preferences/browser/keybindingsEditor.ts', 'src/vs/workbench/contrib/preferences/browser/preferences.contribution.ts', 'src/vs/workbench/contrib/preferences/browser/preferencesRenderers.ts', 'src/vs/workbench/contrib/preferences/browser/settingsEditor2.ts', @@ -762,7 +753,6 @@ export default tseslint.config( 'src/vs/workbench/contrib/searchEditor/browser/searchEditorInput.ts', 'src/vs/workbench/contrib/snippets/browser/commands/configureSnippets.ts', 'src/vs/workbench/contrib/snippets/browser/commands/insertSnippet.ts', - 'src/vs/workbench/contrib/snippets/browser/snippetsFile.ts', 'src/vs/workbench/contrib/snippets/browser/snippetsService.ts', 'src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts', 'src/vs/workbench/contrib/tasks/browser/runAutomaticTasks.ts', @@ -785,9 +775,7 @@ export default tseslint.config( 'src/vs/workbench/contrib/webviewPanel/browser/webviewEditor.ts', 'src/vs/workbench/contrib/webviewPanel/browser/webviewEditorInputSerializer.ts', 'src/vs/workbench/contrib/webviewPanel/browser/webviewWorkbenchService.ts', - 'src/vs/workbench/contrib/webviewView/browser/webviewViewPane.ts', 'src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStarted.ts', - 'src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStartedAccessibleView.ts', 'src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStartedService.ts', 'src/vs/workbench/contrib/welcomeWalkthrough/browser/walkThroughPart.ts', 'src/vs/workbench/services/authentication/common/authentication.ts', diff --git a/src/vs/editor/contrib/find/browser/findWidgetSearchHistory.ts b/src/vs/editor/contrib/find/browser/findWidgetSearchHistory.ts index c065053c4f5..414d3f51bc4 100644 --- a/src/vs/editor/contrib/find/browser/findWidgetSearchHistory.ts +++ b/src/vs/editor/contrib/find/browser/findWidgetSearchHistory.ts @@ -53,7 +53,7 @@ export class FindWidgetSearchHistory implements IHistory { this.save(); } - forEach(callbackfn: (value: string, value2: string, set: Set) => void, thisArg?: any): void { + forEach(callbackfn: (value: string, value2: string, set: Set) => void, thisArg?: unknown): void { // fetch latest from storage this.load(); return this.inMemoryValues.forEach(callbackfn); diff --git a/src/vs/editor/contrib/find/browser/replaceWidgetHistory.ts b/src/vs/editor/contrib/find/browser/replaceWidgetHistory.ts index a570cc7b9e2..45440ed2909 100644 --- a/src/vs/editor/contrib/find/browser/replaceWidgetHistory.ts +++ b/src/vs/editor/contrib/find/browser/replaceWidgetHistory.ts @@ -53,7 +53,7 @@ export class ReplaceWidgetHistory implements IHistory { this.save(); } - forEach(callbackfn: (value: string, value2: string, set: Set) => void, thisArg?: any): void { + forEach(callbackfn: (value: string, value2: string, set: Set) => void, thisArg?: unknown): void { // fetch latest from storage this.load(); return this.inMemoryValues.forEach(callbackfn); diff --git a/src/vs/editor/contrib/folding/browser/folding.ts b/src/vs/editor/contrib/folding/browser/folding.ts index 6c4a72cc721..c42c01a6bc3 100644 --- a/src/vs/editor/contrib/folding/browser/folding.ts +++ b/src/vs/editor/contrib/folding/browser/folding.ts @@ -613,7 +613,7 @@ interface FoldingArguments { selectionLines?: number[]; } -function foldingArgumentsConstraint(args: any) { +function foldingArgumentsConstraint(args: unknown) { if (!types.isUndefined(args)) { if (!types.isObject(args)) { return false; diff --git a/src/vs/platform/keyboardLayout/common/keyboardConfig.ts b/src/vs/platform/keyboardLayout/common/keyboardConfig.ts index 67be262ced3..1cfcb863d90 100644 --- a/src/vs/platform/keyboardLayout/common/keyboardConfig.ts +++ b/src/vs/platform/keyboardLayout/common/keyboardConfig.ts @@ -20,7 +20,7 @@ export interface IKeyboardConfig { } export function readKeyboardConfig(configurationService: IConfigurationService): IKeyboardConfig { - const keyboard = configurationService.getValue<{ dispatch: any; mapAltGrToCtrlAlt: any } | undefined>('keyboard'); + const keyboard = configurationService.getValue<{ dispatch: string; mapAltGrToCtrlAlt: boolean } | undefined>('keyboard'); const dispatch = (keyboard?.dispatch === 'keyCode' ? DispatchConfig.KeyCode : DispatchConfig.Code); const mapAltGrToCtrlAlt = Boolean(keyboard?.mapAltGrToCtrlAlt); return { dispatch, mapAltGrToCtrlAlt }; diff --git a/src/vs/workbench/contrib/bulkEdit/browser/opaqueEdits.ts b/src/vs/workbench/contrib/bulkEdit/browser/opaqueEdits.ts index a8615ee859e..21e16a8e7a8 100644 --- a/src/vs/workbench/contrib/bulkEdit/browser/opaqueEdits.ts +++ b/src/vs/workbench/contrib/bulkEdit/browser/opaqueEdits.ts @@ -13,7 +13,7 @@ import { IUndoRedoService, UndoRedoElementType, UndoRedoGroup, UndoRedoSource } export class ResourceAttachmentEdit extends ResourceEdit implements ICustomEdit { - static is(candidate: any): candidate is ICustomEdit { + static is(candidate: unknown): candidate is ICustomEdit { if (candidate instanceof ResourceAttachmentEdit) { return true; } else { diff --git a/src/vs/workbench/contrib/comments/browser/commentNode.ts b/src/vs/workbench/contrib/comments/browser/commentNode.ts index e0c772782f6..66ea363796f 100644 --- a/src/vs/workbench/contrib/comments/browser/commentNode.ts +++ b/src/vs/workbench/contrib/comments/browser/commentNode.ts @@ -52,7 +52,7 @@ import { IResolvedTextEditorModel, ITextModelService } from '../../../../editor/ import { Position } from '../../../../editor/common/core/position.js'; class CommentsActionRunner extends ActionRunner { - protected override async runAction(action: IAction, context: any[]): Promise { + protected override async runAction(action: IAction, context: unknown[]): Promise { await action.run(...context); } } @@ -279,7 +279,7 @@ export class CommentNode extends Disposable { return result; } - private get commentNodeContext(): [any, MarshalledCommentThread] { + private get commentNodeContext(): [{ thread: languages.CommentThread; commentUniqueId: number; $mid: MarshalledId.CommentNode }, MarshalledCommentThread] { return [{ thread: this.commentThread, commentUniqueId: this.comment.uniqueIdInThread, diff --git a/src/vs/workbench/contrib/issue/browser/issueReporterModel.ts b/src/vs/workbench/contrib/issue/browser/issueReporterModel.ts index 0bbd8acf09a..139ef875c36 100644 --- a/src/vs/workbench/contrib/issue/browser/issueReporterModel.ts +++ b/src/vs/workbench/contrib/issue/browser/issueReporterModel.ts @@ -7,13 +7,18 @@ import { mainWindow } from '../../../../base/browser/window.js'; import { isRemoteDiagnosticError, SystemInfo } from '../../../../platform/diagnostics/common/diagnostics.js'; import { ISettingSearchResult, IssueReporterExtensionData, IssueType } from '../common/issue.js'; +interface VersionInfo { + vscodeVersion: string; + os: string; +} + export interface IssueReporterData { issueType: IssueType; issueDescription?: string; issueTitle?: string; extensionData?: string; - versionInfo?: any; + versionInfo?: VersionInfo; systemInfo?: SystemInfo; systemInfoWeb?: string; processInfo?: string; diff --git a/src/vs/workbench/contrib/notebook/browser/viewParts/notebookViewZones.ts b/src/vs/workbench/contrib/notebook/browser/viewParts/notebookViewZones.ts index b0ade6276a4..652fc736628 100644 --- a/src/vs/workbench/contrib/notebook/browser/viewParts/notebookViewZones.ts +++ b/src/vs/workbench/contrib/notebook/browser/viewParts/notebookViewZones.ts @@ -205,7 +205,7 @@ export class NotebookViewZones extends Disposable { } } -function safeInvoke1Arg(func: Function, arg1: any): void { +function safeInvoke1Arg(func: Function, arg1: unknown): void { try { func(arg1); } catch (e) { diff --git a/src/vs/workbench/contrib/preferences/browser/keybindingsEditor.ts b/src/vs/workbench/contrib/preferences/browser/keybindingsEditor.ts index 076761078d5..d8b8e1cc83a 100644 --- a/src/vs/workbench/contrib/preferences/browser/keybindingsEditor.ts +++ b/src/vs/workbench/contrib/preferences/browser/keybindingsEditor.ts @@ -821,7 +821,7 @@ export class KeybindingsEditor extends EditorPane imp }; } - private onKeybindingEditingError(error: any): void { + private onKeybindingEditingError(error: unknown): void { this.notificationService.error(typeof error === 'string' ? error : localize('error', "Error '{0}' while editing the keybinding. Please open 'keybindings.json' file and check for errors.", `${error}`)); } } diff --git a/src/vs/workbench/contrib/snippets/browser/snippetsFile.ts b/src/vs/workbench/contrib/snippets/browser/snippetsFile.ts index 98829a81bf0..fb981d5bbb7 100644 --- a/src/vs/workbench/contrib/snippets/browser/snippetsFile.ts +++ b/src/vs/workbench/contrib/snippets/browser/snippetsFile.ts @@ -149,7 +149,7 @@ interface JsonSerializedSnippet { description: string; } -function isJsonSerializedSnippet(thing: any): thing is JsonSerializedSnippet { +function isJsonSerializedSnippet(thing: unknown): thing is JsonSerializedSnippet { return isObject(thing) && Boolean((thing).body); } diff --git a/src/vs/workbench/contrib/webviewView/browser/webviewViewPane.ts b/src/vs/workbench/contrib/webviewView/browser/webviewViewPane.ts index cfb107654c8..efa5a1b2b74 100644 --- a/src/vs/workbench/contrib/webviewView/browser/webviewViewPane.ts +++ b/src/vs/workbench/contrib/webviewView/browser/webviewViewPane.ts @@ -53,7 +53,7 @@ export class WebviewViewPane extends ViewPane { private _container?: HTMLElement; private _rootContainer?: HTMLElement; - private _resizeObserver?: any; + private _resizeObserver?: ResizeObserver; private readonly defaultTitle: string; private setTitle: string | undefined; @@ -138,7 +138,7 @@ export class WebviewViewPane extends ViewPane { }); this._register(toDisposable(() => { - this._resizeObserver.disconnect(); + this._resizeObserver?.disconnect(); })); this._resizeObserver.observe(container); } diff --git a/src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStartedAccessibleView.ts b/src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStartedAccessibleView.ts index e1d9858430b..1858285a566 100644 --- a/src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStartedAccessibleView.ts +++ b/src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStartedAccessibleView.ts @@ -92,7 +92,7 @@ class GettingStartedAccessibleProvider extends Disposable implements IAccessible if (isCommand) { const commandURI = URI.parse(command); - let args: any = []; + let args: unknown[] = []; try { args = parse(decodeURIComponent(commandURI.query)); } catch {