From ab2df1ffdc2853fe85bb4da95fe5a4fb89b2da68 Mon Sep 17 00:00:00 2001
From: Johannes Rieken <johannes.rieken@gmail.com>
Date: Mon, 9 Sep 2024 16:52:51 +0200
Subject: [PATCH] tweak chat file suggestions (#227991)

* mark result as incomplete in all cases
* don't include `#file:` in label
* tweak sorting
---
 .../chat/browser/contrib/chatInputCompletions.ts | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/src/vs/workbench/contrib/chat/browser/contrib/chatInputCompletions.ts b/src/vs/workbench/contrib/chat/browser/contrib/chatInputCompletions.ts
index a751a34bf6f..60a91948272 100644
--- a/src/vs/workbench/contrib/chat/browser/contrib/chatInputCompletions.ts
+++ b/src/vs/workbench/contrib/chat/browser/contrib/chatInputCompletions.ts
@@ -382,11 +382,12 @@ class BuiltinDynamicCompletions extends Disposable {
 			const insertText = `${chatVariableLeader}file:${basename} `;
 
 			return {
-				label: { label: `${chatVariableLeader}file:${basename}`, description: this.labelService.getUriLabel(resource) },
+				label: { label: basename, description: this.labelService.getUriLabel(resource) },
+				filterText: info.varWord?.word,
 				insertText,
 				range: info,
 				kind: CompletionItemKind.File,
-				sortText: 'zz',
+				sortText: '{', // after `z`
 				command: {
 					id: BuiltinDynamicCompletions.addReferenceCommand, title: '', arguments: [new ReferenceArgument(widget, {
 						id: 'vscode.file',
@@ -433,7 +434,8 @@ class BuiltinDynamicCompletions extends Disposable {
 		if (pattern) {
 			const query = this.queryBuilder.file(this.workspaceContextService.getWorkspace().folders, {
 				filePattern: pattern,
-				maxResults: 25
+				sortByScore: true,
+				maxResults: 100,
 			});
 
 			const data = await this.searchService.fileSearch(query, token);
@@ -444,11 +446,11 @@ class BuiltinDynamicCompletions extends Disposable {
 				}
 				result.suggestions.push(makeFileCompletionItem(match.resource));
 			}
-
-			if (!data.limitHit) {
-				result.incomplete = true;
-			}
 		}
+
+		// mark results as incomplete because further typing might yield
+		// in more search results
+		result.incomplete = true;
 	}
 
 	private cmdAddReference(arg: ReferenceArgument) {