Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-30 21:41:46 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove active change events

Browse Source
This commit is contained in:
Logan Ramos
2022-04-01 14:24:35 -04:00
parent e9636bbce1
commit acab001237
3 changed files with 0 additions and 170 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/vs/workbench/api/common/extHostEditorTabs.ts
View File

@@ -202,9 +202,7 @@ export class ExtHostEditorTabs implements IExtHostEditorTabs {
private readonly _proxy: MainThreadEditorTabsShape;
private readonly _onDidChangeTabs = new Emitter<vscode.Tab[]>();
private readonly _onDidChangeActiveTab = new Emitter<vscode.Tab>();
private readonly _onDidChangeTabGroups = new Emitter<vscode.TabGroup[]>();
private readonly _onDidChangeActiveTabGroup = new Emitter<vscode.TabGroup>();
// Have to use ! because this gets initialized via an RPC proxy
private _activeGroupId!: number;
@@ -223,9 +221,7 @@ export class ExtHostEditorTabs implements IExtHostEditorTabs {
const obj: vscode.TabGroups = {
// never changes -> simple value
onDidChangeTabGroups: that._onDidChangeTabGroups.event,
onDidChangeActiveTabGroup: that._onDidChangeActiveTabGroup.event,
onDidChangeTabs: that._onDidChangeTabs.event,
onDidChangeActiveTab: that._onDidChangeActiveTab.event,
// dynamic -> getters
get groups() {
return Object.freeze(that._extHostTabGroups.map(group => group.apiObject));
@@ -283,7 +279,6 @@ export class ExtHostEditorTabs implements IExtHostEditorTabs {
const activeTabGroupId = assertIsDefined(tabGroups.find(group => group.isActive === true)?.groupId);
if (activeTabGroupId !== undefined && this._activeGroupId !== activeTabGroupId) {
this._activeGroupId = activeTabGroupId;
this._onDidChangeActiveTabGroup.fire(this.tabGroups.activeTabGroup);
}
this._onDidChangeTabGroups.fire(this._extHostTabGroups.map(g => g.apiObject));
}
@@ -295,11 +290,7 @@ export class ExtHostEditorTabs implements IExtHostEditorTabs {
}
group.acceptGroupDtoUpdate(groupDto);
if (groupDto.isActive) {
const oldActiveGroupId = this._activeGroupId;
this._activeGroupId = groupDto.groupId;
if (oldActiveGroupId !== this._activeGroupId) {
this._onDidChangeActiveTabGroup.fire(group.apiObject);
}
}
this._onDidChangeTabGroups.fire([group.apiObject]);
}
@@ -313,9 +304,6 @@ export class ExtHostEditorTabs implements IExtHostEditorTabs {
// We don't want to fire a change event with a closed tab to prevent an invalid tabs from being received
if (operation.kind !== TabModelOperationKind.TAB_CLOSE) {
this._onDidChangeTabs.fire([tab.apiObject]);
if (tab.apiObject.isActive) {
this._onDidChangeActiveTab.fire(tab.apiObject);
}
}
}
}