Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-01 14:01:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove winpty support (#289025)

Browse Source 
* Bump node-pty to 1.2.0-beta.7

* Deprecate TerminalSettingId.WindowsEnableConpty setting

* Remove windowsEnableConpty instead of deprecating

* Remove WINPTY from ps.ts

* Remove winpty from appropriate comments

* Remove winpty from IProcessReadyWindowsPty

* Remove from classifier.json. TODO on resize for node-pty

* Try adding option to test

* Add reference to issue
This commit is contained in:
Anthony Kim
2026-01-21 08:32:11 -08:00
committed by GitHub
parent 071935f900
commit acb22942b0
18 changed files with 33 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/vscode-api-tests/src/singlefolder-tests/terminal.test.ts
View File

@@ -18,8 +18,6 @@ import { assertNoRpc, poll } from '../utils';
extensionContext = global.testExtensionContext;
const config = workspace.getConfiguration('terminal.integrated');
// Disable conpty in integration tests because of https://github.com/microsoft/vscode/issues/76548
await config.update('windowsEnableConpty', false, ConfigurationTarget.Global);
// Disable exit alerts as tests may trigger then and we're not testing the notifications
await config.update('showExitAlert', false, ConfigurationTarget.Global);
// Canvas may cause problems when running in a container
@@ -70,7 +68,7 @@ import { assertNoRpc, poll } from '../utils';
r(terminal);
}
}));
// Use a single character to avoid winpty/conpty issues with injected sequences
// Use a single character to avoid conpty issues with injected sequences
const terminal = window.createTerminal({
env: { TEST: '`' }
});
@@ -978,7 +976,7 @@ function sanitizeData(data: string): string {
// Strip NL/CR so terminal dimensions don't impact tests
data = data.replace(/[\r\n]/g, '');
// Strip escape sequences so winpty/conpty doesn't cause flakiness, do for all platforms for
// Strip escape sequences so conpty doesn't cause flakiness, do for all platforms for
// consistency
const CSI_SEQUENCE = /(:?(:?\x1b\[|\x9B)[=?>!]?[\d;:]*["$#'* ]?[a-zA-Z@^`{}|~])|(:?\x1b\].*?\x07)/g;
data = data.replace(CSI_SEQUENCE, '');

2
extensions/vscode-api-tests/src/singlefolder-tests/workspace.tasks.test.ts
View File

@@ -13,8 +13,6 @@ import { assertNoRpc } from '../utils';
suiteSetup(async () => {
const config = workspace.getConfiguration('terminal.integrated');
// Disable conpty in integration tests because of https://github.com/microsoft/vscode/issues/76548
await config.update('windowsEnableConpty', false, ConfigurationTarget.Global);
// Disable exit alerts as tests may trigger then and we're not testing the notifications
await config.update('showExitAlert', false, ConfigurationTarget.Global);
// Canvas may cause problems when running in a container