From adcf6b2ddb832ee537ebd0e87a76180f16358a2c Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Wed, 14 Mar 2018 13:54:41 -0700 Subject: [PATCH] Mark public event properties readonly --- src/vs/base/browser/browser.ts | 6 ++--- src/vs/base/browser/ui/findinput/findInput.ts | 22 +++++++++---------- src/vs/base/browser/ui/inputbox/inputBox.ts | 4 ++-- .../browser/ui/scrollbar/scrollableElement.ts | 2 +- src/vs/base/common/scrollable.ts | 2 +- src/vs/editor/browser/config/configuration.ts | 2 +- .../browser/controller/textAreaInput.ts | 22 +++++++++---------- .../editor/browser/widget/codeEditorWidget.ts | 2 +- .../common/config/commonEditorConfig.ts | 4 ++-- src/vs/editor/common/config/editorZoom.ts | 2 +- .../modes/languageConfigurationRegistry.ts | 2 +- src/vs/editor/common/modes/modesRegistry.ts | 2 +- .../common/modes/tokenizationRegistry.ts | 2 +- .../editor/common/view/minimapCharRenderer.ts | 2 +- .../standalone/browser/simpleServices.ts | 2 +- .../test/browser/standaloneLanguages.test.ts | 2 +- .../common/extensionEnablementService.ts | 2 +- .../parts/debug/test/common/mockDebug.ts | 2 +- .../preferences/browser/preferencesEditor.ts | 2 +- .../browser/preferencesRenderers.ts | 2 +- .../preferences/browser/preferencesWidgets.ts | 6 ++--- .../parts/search/browser/searchWidget.ts | 12 +++++----- .../parts/search/common/searchModel.ts | 12 +++++----- .../electron-browser/keybindingService.ts | 2 +- .../textMate/electron-browser/TMSyntax.ts | 4 ++-- 25 files changed, 62 insertions(+), 62 deletions(-) diff --git a/src/vs/base/browser/browser.ts b/src/vs/base/browser/browser.ts index b3013d1dcbc..311c99f15ca 100644 --- a/src/vs/base/browser/browser.ts +++ b/src/vs/base/browser/browser.ts @@ -17,7 +17,7 @@ class WindowManager { private _lastZoomLevelChangeTime: number = 0; private _onDidChangeZoomLevel: Emitter = new Emitter(); - public onDidChangeZoomLevel: Event = this._onDidChangeZoomLevel.event; + public readonly onDidChangeZoomLevel: Event = this._onDidChangeZoomLevel.event; public getZoomLevel(): number { return this._zoomLevel; } @@ -63,7 +63,7 @@ class WindowManager { private _fullscreen: boolean; private _onDidChangeFullscreen: Emitter = new Emitter(); - public onDidChangeFullscreen: Event = this._onDidChangeFullscreen.event; + public readonly onDidChangeFullscreen: Event = this._onDidChangeFullscreen.event; public setFullscreen(fullscreen: boolean): void { if (this._fullscreen === fullscreen) { return; @@ -80,7 +80,7 @@ class WindowManager { private _accessibilitySupport = Platform.AccessibilitySupport.Unknown; private _onDidChangeAccessibilitySupport: Emitter = new Emitter(); - public onDidChangeAccessibilitySupport: Event = this._onDidChangeAccessibilitySupport.event; + public readonly onDidChangeAccessibilitySupport: Event = this._onDidChangeAccessibilitySupport.event; public setAccessibilitySupport(accessibilitySupport: Platform.AccessibilitySupport): void { if (this._accessibilitySupport === accessibilitySupport) { return; diff --git a/src/vs/base/browser/ui/findinput/findInput.ts b/src/vs/base/browser/ui/findinput/findInput.ts index c57c1eb7e71..e0419d1af1d 100644 --- a/src/vs/base/browser/ui/findinput/findInput.ts +++ b/src/vs/base/browser/ui/findinput/findInput.ts @@ -64,23 +64,23 @@ export class FindInput extends Widget { public domNode: HTMLElement; public inputBox: InputBox; - private _onDidOptionChange = this._register(new Emitter()); - public onDidOptionChange: Event = this._onDidOptionChange.event; + private readonly _onDidOptionChange = this._register(new Emitter()); + public readonly onDidOptionChange: Event = this._onDidOptionChange.event; - private _onKeyDown = this._register(new Emitter()); - public onKeyDown: Event = this._onKeyDown.event; + private readonly _onKeyDown = this._register(new Emitter()); + public readonly onKeyDown: Event = this._onKeyDown.event; - private _onMouseDown = this._register(new Emitter()); - public onMouseDown: Event = this._onMouseDown.event; + private readonly _onMouseDown = this._register(new Emitter()); + public readonly onMouseDown: Event = this._onMouseDown.event; - private _onInput = this._register(new Emitter()); - public onInput: Event = this._onInput.event; + private readonly _onInput = this._register(new Emitter()); + public readonly onInput: Event = this._onInput.event; - private _onKeyUp = this._register(new Emitter()); - public onKeyUp: Event = this._onKeyUp.event; + private readonly _onKeyUp = this._register(new Emitter()); + public readonly onKeyUp: Event = this._onKeyUp.event; private _onCaseSensitiveKeyDown = this._register(new Emitter()); - public onCaseSensitiveKeyDown: Event = this._onCaseSensitiveKeyDown.event; + public readonly onCaseSensitiveKeyDown: Event = this._onCaseSensitiveKeyDown.event; constructor(parent: HTMLElement, contextViewProvider: IContextViewProvider, options?: IFindInputOptions) { super(); diff --git a/src/vs/base/browser/ui/inputbox/inputBox.ts b/src/vs/base/browser/ui/inputbox/inputBox.ts index 68b3d5fb68f..52e37d7c0f4 100644 --- a/src/vs/base/browser/ui/inputbox/inputBox.ts +++ b/src/vs/base/browser/ui/inputbox/inputBox.ts @@ -104,10 +104,10 @@ export class InputBox extends Widget { private inputValidationErrorBackground: Color; private _onDidChange = this._register(new Emitter()); - public onDidChange: Event = this._onDidChange.event; + public readonly onDidChange: Event = this._onDidChange.event; private _onDidHeightChange = this._register(new Emitter()); - public onDidHeightChange: Event = this._onDidHeightChange.event; + public readonly onDidHeightChange: Event = this._onDidHeightChange.event; constructor(container: HTMLElement, contextViewProvider: IContextViewProvider, options?: IInputOptions) { super(); diff --git a/src/vs/base/browser/ui/scrollbar/scrollableElement.ts b/src/vs/base/browser/ui/scrollbar/scrollableElement.ts index aa385800dae..f643a5ca2a0 100644 --- a/src/vs/base/browser/ui/scrollbar/scrollableElement.ts +++ b/src/vs/base/browser/ui/scrollbar/scrollableElement.ts @@ -164,7 +164,7 @@ export abstract class AbstractScrollableElement extends Widget { private _shouldRender: boolean; private readonly _onScroll = this._register(new Emitter()); - public onScroll: Event = this._onScroll.event; + public readonly onScroll: Event = this._onScroll.event; protected constructor(element: HTMLElement, options: ScrollableElementCreationOptions, scrollable?: Scrollable) { super(); diff --git a/src/vs/base/common/scrollable.ts b/src/vs/base/common/scrollable.ts index b65c20586f6..520681c8041 100644 --- a/src/vs/base/common/scrollable.ts +++ b/src/vs/base/common/scrollable.ts @@ -186,7 +186,7 @@ export class Scrollable extends Disposable { private _smoothScrolling: SmoothScrollingOperation; private _onScroll = this._register(new Emitter()); - public onScroll: Event = this._onScroll.event; + public readonly onScroll: Event = this._onScroll.event; constructor(smoothScrollDuration: number, scheduleAtNextAnimationFrame: (callback: () => void) => IDisposable) { super(); diff --git a/src/vs/editor/browser/config/configuration.ts b/src/vs/editor/browser/config/configuration.ts index 3168410001b..92552342068 100644 --- a/src/vs/editor/browser/config/configuration.ts +++ b/src/vs/editor/browser/config/configuration.ts @@ -102,7 +102,7 @@ class CSSBasedConfiguration extends Disposable { private _evictUntrustedReadingsTimeout: number; private _onDidChange = this._register(new Emitter()); - public onDidChange: Event = this._onDidChange.event; + public readonly onDidChange: Event = this._onDidChange.event; constructor() { super(); diff --git a/src/vs/editor/browser/controller/textAreaInput.ts b/src/vs/editor/browser/controller/textAreaInput.ts index ea9cf23d22d..cc91f4aaf93 100644 --- a/src/vs/editor/browser/controller/textAreaInput.ts +++ b/src/vs/editor/browser/controller/textAreaInput.ts @@ -53,37 +53,37 @@ export interface ITextAreaInputHost { export class TextAreaInput extends Disposable { private _onFocus = this._register(new Emitter()); - public onFocus: Event = this._onFocus.event; + public readonly onFocus: Event = this._onFocus.event; private _onBlur = this._register(new Emitter()); - public onBlur: Event = this._onBlur.event; + public readonly onBlur: Event = this._onBlur.event; private _onKeyDown = this._register(new Emitter()); - public onKeyDown: Event = this._onKeyDown.event; + public readonly onKeyDown: Event = this._onKeyDown.event; private _onKeyUp = this._register(new Emitter()); - public onKeyUp: Event = this._onKeyUp.event; + public readonly onKeyUp: Event = this._onKeyUp.event; private _onCut = this._register(new Emitter()); - public onCut: Event = this._onCut.event; + public readonly onCut: Event = this._onCut.event; private _onPaste = this._register(new Emitter()); - public onPaste: Event = this._onPaste.event; + public readonly onPaste: Event = this._onPaste.event; private _onType = this._register(new Emitter()); - public onType: Event = this._onType.event; + public readonly onType: Event = this._onType.event; private _onCompositionStart = this._register(new Emitter()); - public onCompositionStart: Event = this._onCompositionStart.event; + public readonly onCompositionStart: Event = this._onCompositionStart.event; private _onCompositionUpdate = this._register(new Emitter()); - public onCompositionUpdate: Event = this._onCompositionUpdate.event; + public readonly onCompositionUpdate: Event = this._onCompositionUpdate.event; private _onCompositionEnd = this._register(new Emitter()); - public onCompositionEnd: Event = this._onCompositionEnd.event; + public readonly onCompositionEnd: Event = this._onCompositionEnd.event; private _onSelectionChangeRequest = this._register(new Emitter()); - public onSelectionChangeRequest: Event = this._onSelectionChangeRequest.event; + public readonly onSelectionChangeRequest: Event = this._onSelectionChangeRequest.event; // --- diff --git a/src/vs/editor/browser/widget/codeEditorWidget.ts b/src/vs/editor/browser/widget/codeEditorWidget.ts index 71795b7021b..baa9e9be9fa 100644 --- a/src/vs/editor/browser/widget/codeEditorWidget.ts +++ b/src/vs/editor/browser/widget/codeEditorWidget.ts @@ -456,7 +456,7 @@ class CodeEditorWidgetFocusTracker extends Disposable { private _domFocusTracker: dom.IFocusTracker; private _onChange: Emitter = this._register(new Emitter()); - public onChange: Event = this._onChange.event; + public readonly onChange: Event = this._onChange.event; constructor(domElement: HTMLElement) { super(); diff --git a/src/vs/editor/common/config/commonEditorConfig.ts b/src/vs/editor/common/config/commonEditorConfig.ts index 73339f9d245..a1e2e35c041 100644 --- a/src/vs/editor/common/config/commonEditorConfig.ts +++ b/src/vs/editor/common/config/commonEditorConfig.ts @@ -35,7 +35,7 @@ export const TabFocus: ITabFocus = new class implements ITabFocus { private _tabFocus: boolean = false; private _onDidChangeTabFocus: Emitter = new Emitter(); - public onDidChangeTabFocus: Event = this._onDidChangeTabFocus.event; + public readonly onDidChangeTabFocus: Event = this._onDidChangeTabFocus.event; public getTabFocusMode(): boolean { return this._tabFocus; @@ -70,7 +70,7 @@ export abstract class CommonEditorConfiguration extends Disposable implements ed private _lineNumbersDigitCount: number; private _onDidChange = this._register(new Emitter()); - public onDidChange: Event = this._onDidChange.event; + public readonly onDidChange: Event = this._onDidChange.event; constructor(options: editorOptions.IEditorOptions) { super(); diff --git a/src/vs/editor/common/config/editorZoom.ts b/src/vs/editor/common/config/editorZoom.ts index 1e560c48beb..2c3efe550e3 100644 --- a/src/vs/editor/common/config/editorZoom.ts +++ b/src/vs/editor/common/config/editorZoom.ts @@ -17,7 +17,7 @@ export const EditorZoom: IEditorZoom = new class implements IEditorZoom { private _zoomLevel: number = 0; private _onDidChangeZoomLevel: Emitter = new Emitter(); - public onDidChangeZoomLevel: Event = this._onDidChangeZoomLevel.event; + public readonly onDidChangeZoomLevel: Event = this._onDidChangeZoomLevel.event; public getZoomLevel(): number { return this._zoomLevel; diff --git a/src/vs/editor/common/modes/languageConfigurationRegistry.ts b/src/vs/editor/common/modes/languageConfigurationRegistry.ts index a697e260e5d..6eb3521ff47 100644 --- a/src/vs/editor/common/modes/languageConfigurationRegistry.ts +++ b/src/vs/editor/common/modes/languageConfigurationRegistry.ts @@ -178,7 +178,7 @@ export class LanguageConfigurationRegistryImpl { private _entries: RichEditSupport[]; private _onDidChange: Emitter = new Emitter(); - public onDidChange: Event = this._onDidChange.event; + public readonly onDidChange: Event = this._onDidChange.event; constructor() { this._entries = []; diff --git a/src/vs/editor/common/modes/modesRegistry.ts b/src/vs/editor/common/modes/modesRegistry.ts index b6dd9ce31cd..346f1a8f7c7 100644 --- a/src/vs/editor/common/modes/modesRegistry.ts +++ b/src/vs/editor/common/modes/modesRegistry.ts @@ -21,7 +21,7 @@ export class EditorModesRegistry { private _languages: ILanguageExtensionPoint[]; private _onDidAddLanguages: Emitter = new Emitter(); - public onDidAddLanguages: Event = this._onDidAddLanguages.event; + public readonly onDidAddLanguages: Event = this._onDidAddLanguages.event; constructor() { this._languages = []; diff --git a/src/vs/editor/common/modes/tokenizationRegistry.ts b/src/vs/editor/common/modes/tokenizationRegistry.ts index 353a080bd57..f97b6319606 100644 --- a/src/vs/editor/common/modes/tokenizationRegistry.ts +++ b/src/vs/editor/common/modes/tokenizationRegistry.ts @@ -14,7 +14,7 @@ export class TokenizationRegistryImpl implements ITokenizationRegistry { private _map: { [language: string]: ITokenizationSupport }; private _onDidChange: Emitter = new Emitter(); - public onDidChange: Event = this._onDidChange.event; + public readonly onDidChange: Event = this._onDidChange.event; private _colorMap: Color[]; diff --git a/src/vs/editor/common/view/minimapCharRenderer.ts b/src/vs/editor/common/view/minimapCharRenderer.ts index 33baf72b9fe..24bbf7bd46d 100644 --- a/src/vs/editor/common/view/minimapCharRenderer.ts +++ b/src/vs/editor/common/view/minimapCharRenderer.ts @@ -21,7 +21,7 @@ export class MinimapTokensColorTracker { private _backgroundIsLight: boolean; private _onDidChange = new Emitter(); - public onDidChange: Event = this._onDidChange.event; + public readonly onDidChange: Event = this._onDidChange.event; private constructor() { this._updateColorMap(); diff --git a/src/vs/editor/standalone/browser/simpleServices.ts b/src/vs/editor/standalone/browser/simpleServices.ts index cd28bc5c120..20bcbe47fb7 100644 --- a/src/vs/editor/standalone/browser/simpleServices.ts +++ b/src/vs/editor/standalone/browser/simpleServices.ts @@ -472,7 +472,7 @@ export class SimpleConfigurationService implements IConfigurationService { _serviceBrand: any; private _onDidChangeConfiguration = new Emitter(); - public onDidChangeConfiguration: Event = this._onDidChangeConfiguration.event; + public readonly onDidChangeConfiguration: Event = this._onDidChangeConfiguration.event; private _configuration: Configuration; diff --git a/src/vs/editor/standalone/test/browser/standaloneLanguages.test.ts b/src/vs/editor/standalone/test/browser/standaloneLanguages.test.ts index 7a8aba76b47..39325ac95a8 100644 --- a/src/vs/editor/standalone/test/browser/standaloneLanguages.test.ts +++ b/src/vs/editor/standalone/test/browser/standaloneLanguages.test.ts @@ -58,7 +58,7 @@ suite('TokenizationSupport2Adapter', () => { } }; } - public onThemeChange: Event = null; + public readonly onThemeChange: Event = null; } class MockState implements IState { diff --git a/src/vs/platform/extensionManagement/common/extensionEnablementService.ts b/src/vs/platform/extensionManagement/common/extensionEnablementService.ts index 4e4fbc25a3d..708c1980eea 100644 --- a/src/vs/platform/extensionManagement/common/extensionEnablementService.ts +++ b/src/vs/platform/extensionManagement/common/extensionEnablementService.ts @@ -23,7 +23,7 @@ export class ExtensionEnablementService implements IExtensionEnablementService { private disposables: IDisposable[] = []; private _onEnablementChanged = new Emitter(); - public onEnablementChanged: Event = this._onEnablementChanged.event; + public readonly onEnablementChanged: Event = this._onEnablementChanged.event; constructor( @IStorageService private storageService: IStorageService, diff --git a/src/vs/workbench/parts/debug/test/common/mockDebug.ts b/src/vs/workbench/parts/debug/test/common/mockDebug.ts index fec5a6e4086..17c34a94ab8 100644 --- a/src/vs/workbench/parts/debug/test/common/mockDebug.ts +++ b/src/vs/workbench/parts/debug/test/common/mockDebug.ts @@ -249,5 +249,5 @@ export class MockSession implements ISession { return TPromise.as(null); } - public onDidStop: Event = null; + public readonly onDidStop: Event = null; } diff --git a/src/vs/workbench/parts/preferences/browser/preferencesEditor.ts b/src/vs/workbench/parts/preferences/browser/preferencesEditor.ts index f8e885ac997..7c23c490cbb 100644 --- a/src/vs/workbench/parts/preferences/browser/preferencesEditor.ts +++ b/src/vs/workbench/parts/preferences/browser/preferencesEditor.ts @@ -399,7 +399,7 @@ class PreferencesRenderersController extends Disposable { private _lastFilterResult: IFilterResult; private _onDidFilterResultsCountChange: Emitter = this._register(new Emitter()); - public onDidFilterResultsCountChange: Event = this._onDidFilterResultsCountChange.event; + public readonly onDidFilterResultsCountChange: Event = this._onDidFilterResultsCountChange.event; constructor( @IPreferencesSearchService private preferencesSearchService: IPreferencesSearchService, diff --git a/src/vs/workbench/parts/preferences/browser/preferencesRenderers.ts b/src/vs/workbench/parts/preferences/browser/preferencesRenderers.ts index 2985ca57dd0..7414cc58673 100644 --- a/src/vs/workbench/parts/preferences/browser/preferencesRenderers.ts +++ b/src/vs/workbench/parts/preferences/browser/preferencesRenderers.ts @@ -465,7 +465,7 @@ export class BracesHidingRenderer extends Disposable implements HiddenAreasProvi class DefaultSettingsHeaderRenderer extends Disposable { private settingsHeaderWidget: DefaultSettingsHeaderWidget; - public onClick: Event; + public readonly onClick: Event; constructor(editor: ICodeEditor, scope: ConfigurationScope) { super(); diff --git a/src/vs/workbench/parts/preferences/browser/preferencesWidgets.ts b/src/vs/workbench/parts/preferences/browser/preferencesWidgets.ts index 66a19e88887..27f5b4b6522 100644 --- a/src/vs/workbench/parts/preferences/browser/preferencesWidgets.ts +++ b/src/vs/workbench/parts/preferences/browser/preferencesWidgets.ts @@ -102,7 +102,7 @@ export class SettingsHeaderWidget extends Widget implements IViewZone { export class DefaultSettingsHeaderWidget extends SettingsHeaderWidget { private _onClick = this._register(new Emitter()); - public onClick: Event = this._onClick.event; + public readonly onClick: Event = this._onClick.event; protected create() { super.create(); @@ -130,7 +130,7 @@ export class SettingsGroupTitleWidget extends Widget implements IViewZone { private title: HTMLElement; private _onToggled = this._register(new Emitter()); - public onToggled: Event = this._onToggled.event; + public readonly onToggled: Event = this._onToggled.event; private previousPosition: Position; @@ -706,7 +706,7 @@ export class FloatingClickWidget extends Widget implements IOverlayWidget { private _domNode: HTMLElement; private _onClick: Emitter = this._register(new Emitter()); - public onClick: Event = this._onClick.event; + public readonly onClick: Event = this._onClick.event; constructor( private editor: ICodeEditor, diff --git a/src/vs/workbench/parts/search/browser/searchWidget.ts b/src/vs/workbench/parts/search/browser/searchWidget.ts index 3812452fc30..3bc778436d8 100644 --- a/src/vs/workbench/parts/search/browser/searchWidget.ts +++ b/src/vs/workbench/parts/search/browser/searchWidget.ts @@ -100,22 +100,22 @@ export class SearchWidget extends Widget { private previousGlobalFindBufferValue: string; private _onSearchSubmit = this._register(new Emitter()); - public onSearchSubmit: Event = this._onSearchSubmit.event; + public readonly onSearchSubmit: Event = this._onSearchSubmit.event; private _onSearchCancel = this._register(new Emitter()); - public onSearchCancel: Event = this._onSearchCancel.event; + public readonly onSearchCancel: Event = this._onSearchCancel.event; private _onReplaceToggled = this._register(new Emitter()); - public onReplaceToggled: Event = this._onReplaceToggled.event; + public readonly onReplaceToggled: Event = this._onReplaceToggled.event; private _onReplaceStateChange = this._register(new Emitter()); - public onReplaceStateChange: Event = this._onReplaceStateChange.event; + public readonly onReplaceStateChange: Event = this._onReplaceStateChange.event; private _onReplaceValueChanged = this._register(new Emitter()); - public onReplaceValueChanged: Event = this._onReplaceValueChanged.event; + public readonly onReplaceValueChanged: Event = this._onReplaceValueChanged.event; private _onReplaceAll = this._register(new Emitter()); - public onReplaceAll: Event = this._onReplaceAll.event; + public readonly onReplaceAll: Event = this._onReplaceAll.event; constructor( container: Builder, diff --git a/src/vs/workbench/parts/search/common/searchModel.ts b/src/vs/workbench/parts/search/common/searchModel.ts index 889782b1aa7..8b9007ddb12 100644 --- a/src/vs/workbench/parts/search/common/searchModel.ts +++ b/src/vs/workbench/parts/search/common/searchModel.ts @@ -118,10 +118,10 @@ export class FileMatch extends Disposable { } private _onChange = this._register(new Emitter()); - public onChange: Event = this._onChange.event; + public readonly onChange: Event = this._onChange.event; private _onDispose = this._register(new Emitter()); - public onDispose: Event = this._onDispose.event; + public readonly onDispose: Event = this._onDispose.event; private _resource: URI; private _model: ITextModel; @@ -338,10 +338,10 @@ export interface IChangeEvent { export class FolderMatch extends Disposable { private _onChange = this._register(new Emitter()); - public onChange: Event = this._onChange.event; + public readonly onChange: Event = this._onChange.event; private _onDispose = this._register(new Emitter()); - public onDispose: Event = this._onDispose.event; + public readonly onDispose: Event = this._onDispose.event; private _fileMatches: ResourceMap; private _unDisposedFileMatches: ResourceMap; @@ -499,7 +499,7 @@ export class FolderMatch extends Disposable { export class SearchResult extends Disposable { private _onChange = this._register(new Emitter()); - public onChange: Event = this._onChange.event; + public readonly onChange: Event = this._onChange.event; private _folderMatches: FolderMatch[] = []; private _folderMatchesMap: TernarySearchTree = TernarySearchTree.forPaths(); @@ -683,7 +683,7 @@ export class SearchModel extends Disposable { private _replacePattern: ReplacePattern = null; private _onReplaceTermChanged: Emitter = this._register(new Emitter()); - public onReplaceTermChanged: Event = this._onReplaceTermChanged.event; + public readonly onReplaceTermChanged: Event = this._onReplaceTermChanged.event; private currentRequest: PPromise; diff --git a/src/vs/workbench/services/keybinding/electron-browser/keybindingService.ts b/src/vs/workbench/services/keybinding/electron-browser/keybindingService.ts index 1b5795bd29c..b502f9e0b9d 100644 --- a/src/vs/workbench/services/keybinding/electron-browser/keybindingService.ts +++ b/src/vs/workbench/services/keybinding/electron-browser/keybindingService.ts @@ -47,7 +47,7 @@ export class KeyboardMapperFactory { private _initialized: boolean; private _onDidChangeKeyboardMapper: Emitter = new Emitter(); - public onDidChangeKeyboardMapper: Event = this._onDidChangeKeyboardMapper.event; + public readonly onDidChangeKeyboardMapper: Event = this._onDidChangeKeyboardMapper.event; private constructor() { this._layoutInfo = null; diff --git a/src/vs/workbench/services/textMate/electron-browser/TMSyntax.ts b/src/vs/workbench/services/textMate/electron-browser/TMSyntax.ts index 2fe97c36656..b1fc901210c 100644 --- a/src/vs/workbench/services/textMate/electron-browser/TMSyntax.ts +++ b/src/vs/workbench/services/textMate/electron-browser/TMSyntax.ts @@ -29,7 +29,7 @@ export class TMScopeRegistry { private _encounteredLanguages: boolean[]; private _onDidEncounterLanguage: Emitter = new Emitter(); - public onDidEncounterLanguage: Event = this._onDidEncounterLanguage.event; + public readonly onDidEncounterLanguage: Event = this._onDidEncounterLanguage.event; constructor() { this._scopeNameToLanguageRegistration = Object.create(null); @@ -122,7 +122,7 @@ export class TextMateService implements ITextMateService { private _currentTokenColors: ITokenColorizationRule[]; - public onDidEncounterLanguage: Event; + public readonly onDidEncounterLanguage: Event; constructor( @IModeService modeService: IModeService,