From adfa191fecd974176ace72a11f8d363ea8a422fb Mon Sep 17 00:00:00 2001
From: Justin Chen <54879025+justschen@users.noreply.github.com>
Date: Thu, 21 Mar 2024 16:51:06 -0700
Subject: [PATCH] adds limit on issue reporter description (#208346)
---
.../electron-sandbox/issue/issueReporterPage.ts | 1 +
.../electron-sandbox/issue/issueReporterService.ts | 13 ++++++++++++-
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/src/vs/code/electron-sandbox/issue/issueReporterPage.ts b/src/vs/code/electron-sandbox/issue/issueReporterPage.ts
index bf5dca66aeb..01e08122492 100644
--- a/src/vs/code/electron-sandbox/issue/issueReporterPage.ts
+++ b/src/vs/code/electron-sandbox/issue/issueReporterPage.ts
@@ -83,6 +83,7 @@ export default (): string => `
${escape(localize('descriptionEmptyValidation', "A description is required."))}
+ ${escape(localize('descriptionTooShortValidation', "Please provide a longer description."))}
diff --git a/src/vs/code/electron-sandbox/issue/issueReporterService.ts b/src/vs/code/electron-sandbox/issue/issueReporterService.ts
index ebc539729d1..ac9f828bd0f 100644
--- a/src/vs/code/electron-sandbox/issue/issueReporterService.ts
+++ b/src/vs/code/electron-sandbox/issue/issueReporterService.ts
@@ -924,13 +924,24 @@ export class IssueReporter extends Disposable {
private validateInput(inputId: string): boolean {
const inputElement = (this.getElementById(inputId));
const inputValidationMessage = this.getElementById(`${inputId}-empty-error`);
+ const descriptionShortMessage = this.getElementById(`description-short-error`);
if (!inputElement.value) {
inputElement.classList.add('invalid-input');
inputValidationMessage?.classList.remove('hidden');
+ descriptionShortMessage?.classList.add('hidden');
return false;
- } else {
+ } else if (inputId === 'description' && inputElement.value.length < 10) {
+ inputElement.classList.add('invalid-input');
+ descriptionShortMessage?.classList.remove('hidden');
+ inputValidationMessage?.classList.add('hidden');
+ return false;
+ }
+ else {
inputElement.classList.remove('invalid-input');
inputValidationMessage?.classList.add('hidden');
+ if (inputId === 'description') {
+ descriptionShortMessage?.classList.add('hidden');
+ }
return true;
}
}