From ae1670d4ea5e2ef4dad298be02b318ff4692652b Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Fri, 24 Apr 2020 06:27:52 -0700 Subject: [PATCH] Disable terminal tests in remote Too flaky they're not useful. See #96057 --- .../src/singlefolder-tests/terminal.test.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/extensions/vscode-api-tests/src/singlefolder-tests/terminal.test.ts b/extensions/vscode-api-tests/src/singlefolder-tests/terminal.test.ts index a1e9863d498..95d54cdca99 100644 --- a/extensions/vscode-api-tests/src/singlefolder-tests/terminal.test.ts +++ b/extensions/vscode-api-tests/src/singlefolder-tests/terminal.test.ts @@ -6,8 +6,10 @@ import { window, Pseudoterminal, EventEmitter, TerminalDimensions, workspace, ConfigurationTarget, Disposable, UIKind, env, EnvironmentVariableMutatorType, EnvironmentVariableMutator } from 'vscode'; import { doesNotThrow, equal, ok, deepEqual, throws } from 'assert'; -// TODO@Daniel flaky tests (https://github.com/microsoft/vscode/issues/92826) -((env.uiKind === UIKind.Web) ? suite.skip : suite)('vscode API - terminal', () => { +// Disable terminal tests: +// - Web https://github.com/microsoft/vscode/issues/92826 +// - Remote https://github.com/microsoft/vscode/issues/96057 +((env.uiKind === UIKind.Web || typeof env.remoteName !== 'undefined') ? suite.skip : suite)('vscode API - terminal', () => { suiteSetup(async () => { const config = workspace.getConfiguration('terminal.integrated'); // Disable conpty in integration tests because of https://github.com/microsoft/vscode/issues/76548