From ae684437a36fbf020a8dbef2cfd1c9058eacf0e5 Mon Sep 17 00:00:00 2001 From: Rachel Macfarlane Date: Mon, 1 Jun 2020 10:24:54 -0700 Subject: [PATCH] Do not show option to sign into GitHub when already signed in for preferences sync, fixes #97735 --- .../userDataSync/browser/userDataSyncWorkbenchService.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/vs/workbench/services/userDataSync/browser/userDataSyncWorkbenchService.ts b/src/vs/workbench/services/userDataSync/browser/userDataSyncWorkbenchService.ts index 81a3e2c1a50..343d988c062 100644 --- a/src/vs/workbench/services/userDataSync/browser/userDataSyncWorkbenchService.ts +++ b/src/vs/workbench/services/userDataSync/browser/userDataSyncWorkbenchService.ts @@ -365,8 +365,11 @@ export class UserDataSyncWorkbenchService extends Disposable implements IUserDat // Account proviers for (const authenticationProvider of this.authenticationProviders) { - const providerName = this.authenticationService.getDisplayName(authenticationProvider.id); - quickPickItems.push({ label: localize('sign in using account', "Sign in with {0}", providerName), authenticationProvider }); + const signedInForProvider = this.all.some(account => account.authenticationProviderId === authenticationProvider.id); + if (!signedInForProvider || this.authenticationService.supportsMultipleAccounts(authenticationProvider.id)) { + const providerName = this.authenticationService.getDisplayName(authenticationProvider.id); + quickPickItems.push({ label: localize('sign in using account', "Sign in with {0}", providerName), authenticationProvider }); + } } return quickPickItems;