From af67d7303c36b306b60de0e6b03cc668c9dfdafd Mon Sep 17 00:00:00 2001 From: Sandeep Somavarapu Date: Wed, 17 Nov 2021 11:00:09 +0100 Subject: [PATCH] add note why spdlog is used in ext host --- src/vs/workbench/api/node/extHostLoggerService.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/vs/workbench/api/node/extHostLoggerService.ts b/src/vs/workbench/api/node/extHostLoggerService.ts index 67d9d52e055..d25dd875169 100644 --- a/src/vs/workbench/api/node/extHostLoggerService.ts +++ b/src/vs/workbench/api/node/extHostLoggerService.ts @@ -14,6 +14,7 @@ export class ExtHostLoggerService extends BaseExtHostLoggerService { protected override doCreateLogger(resource: URI, logLevel: LogLevel, options?: ILoggerOptions): ILogger { if (resource.scheme === Schemas.file) { + /* Create the logger in the Extension Host process to prevent loggers (log, output channels...) traffic over IPC */ return new SpdLogLogger(options?.name || generateUuid(), resource.fsPath, !options?.donotRotate, !!options?.donotUseFormatters, logLevel); } return super.doCreateLogger(resource, logLevel, options);