From afa4a2df2c3e2ea26985c545ab05cd616aaa107d Mon Sep 17 00:00:00 2001 From: Johannes Rieken Date: Thu, 15 Apr 2021 16:19:06 +0200 Subject: [PATCH] rename to serializeNotebook and deserializeNotebook, https://github.com/microsoft/vscode/issues/121329 --- src/vs/vscode.proposed.d.ts | 4 ++-- src/vs/workbench/api/common/extHostNotebook.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/vs/vscode.proposed.d.ts b/src/vs/vscode.proposed.d.ts index a953cac0779..82a0202fff3 100644 --- a/src/vs/vscode.proposed.d.ts +++ b/src/vs/vscode.proposed.d.ts @@ -1404,8 +1404,8 @@ declare module 'vscode' { //#region https://github.com/microsoft/vscode/issues/106744, NotebookSerializer export interface NotebookSerializer { - dataToNotebook(data: Uint8Array): NotebookData | Thenable; - notebookToData(data: NotebookData): Uint8Array | Thenable; + deserializeNotebook(data: Uint8Array): NotebookData | Thenable; + serializeNotebook(data: NotebookData): Uint8Array | Thenable; } export namespace notebook { diff --git a/src/vs/workbench/api/common/extHostNotebook.ts b/src/vs/workbench/api/common/extHostNotebook.ts index 43c6f6df2c3..36b67ed2e03 100644 --- a/src/vs/workbench/api/common/extHostNotebook.ts +++ b/src/vs/workbench/api/common/extHostNotebook.ts @@ -572,7 +572,7 @@ export class ExtHostNotebookController implements ExtHostNotebookShape { if (!serializer) { throw new Error('NO serializer found'); } - const data = await serializer.dataToNotebook(bytes.buffer); + const data = await serializer.deserializeNotebook(bytes.buffer); return { metadata: typeConverters.NotebookDocumentMetadata.from(data.metadata), cells: data.cells.map(typeConverters.NotebookCellData.from), @@ -584,7 +584,7 @@ export class ExtHostNotebookController implements ExtHostNotebookShape { if (!serializer) { throw new Error('NO serializer found'); } - const bytes = await serializer.notebookToData({ + const bytes = await serializer.serializeNotebook({ metadata: typeConverters.NotebookDocumentMetadata.to(data.metadata), cells: data.cells.map(typeConverters.NotebookCellData.to) });