Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-19 08:08:39 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add diagnostic manager enablement change tests (#152392)

Browse Source 
* Add test for MD diagnostic manager config changes

Add a simple test the enabling/disable diagnostics should make the diagnostic manager recompute diagnostics

* Add `.get`
This commit is contained in:
Matt Bierner
2022-06-16 15:53:19 -07:00
committed by GitHub
parent 9740164159
commit afe316c08c
2 changed files with 90 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
extensions/markdown-language-features/src/languageFeatures/diagnostics.ts
View File

@@ -231,7 +231,7 @@ class LinkDoesNotExistDiagnostic extends vscode.Diagnostic {
}
export abstract class DiagnosticReporter extends Disposable {
private readonly pending = new ResourceMap<Promise<any>>();
private readonly pending = new Set<Promise<any>>();
public clear(): void {
this.pending.clear();
@@ -239,20 +239,15 @@ export abstract class DiagnosticReporter extends Disposable {
public abstract set(uri: vscode.Uri, diagnostics: readonly vscode.Diagnostic[]): void;
public delete(uri: vscode.Uri): void {
this.pending.delete(uri);
public abstract delete(uri: vscode.Uri): void;
public addWorkItem(promise: Promise<any>): Promise<any> {
this.pending.add(promise);
promise.finally(() => this.pending.delete(promise));
return promise;
}
public signalTriggered(uri: vscode.Uri, recompute: Promise<any>): void {
this.pending.set(uri, recompute);
recompute.finally(() => {
if (this.pending.get(uri) === recompute) {
this.pending.delete(uri);
}
});
}
public async waitAllPending(): Promise<void> {
public async waitPendingWork(): Promise<void> {
await Promise.all([...this.pending.values()]);
}
}
@@ -276,8 +271,7 @@ export class DiagnosticCollectionReporter extends DiagnosticReporter {
this.collection.set(uri, tabs.has(uri) ? diagnostics : []);
}
public override delete(uri: vscode.Uri): void {
super.delete(uri);
public delete(uri: vscode.Uri): void {
this.collection.delete(uri);
}
@@ -391,21 +385,26 @@ export class DiagnosticManager extends Disposable {
}));
}
private async rebuild() {
private rebuild(): Promise<void> {
this.reporter.clear();
this.pendingDiagnostics.clear();
this.inFlightDiagnostics.clear();
for (const doc of await this.workspaceContents.getAllMarkdownDocuments()) {
this.triggerDiagnostics(doc.uri);
}
return this.reporter.addWorkItem(
(async () => {
const allDocs = await this.workspaceContents.getAllMarkdownDocuments();
await Promise.all(Array.from(allDocs, doc => this.triggerDiagnostics(doc.uri)));
})()
);
}
private triggerDiagnostics(uri: vscode.Uri) {
private async triggerDiagnostics(uri: vscode.Uri): Promise<void> {
this.inFlightDiagnostics.cancel(uri);
this.pendingDiagnostics.add(uri);
this.reporter.signalTriggered(uri, this.diagnosticDelayer.trigger(() => this.recomputePendingDiagnostics()));
return this.reporter.addWorkItem(
this.diagnosticDelayer.trigger(() => this.recomputePendingDiagnostics())
);
}
}