Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-25 11:08:51 +01:00
Code Issues Packages Projects Releases Wiki Activity

Towards aligning ISuggestSupport with ext host API

Browse Source
This commit is contained in:
Alex Dima
2016-05-19 15:22:49 +02:00
parent 227878250b
commit b12575b4f4
28 changed files with 132 additions and 115 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/vs/workbench/api/node/extHostLanguageFeatures.ts
View File

@@ -469,15 +469,7 @@ interface ISuggestion2 extends modes.ISuggestion {
id: string;
}
class SuggestAdapter implements modes.ISuggestSupport {
public get triggerCharacters(): string[] {
throw new Error('illegal state');
}
public get shouldAutotriggerSuggest(): boolean {
throw new Error('illegal state');
}
class SuggestAdapter {
private _documents: ExtHostModelService;
private _provider: vscode.CompletionItemProvider;
@@ -997,8 +989,8 @@ export class MainThreadLanguageFeatures {
this._registrations[handle] = modes.SuggestRegistry.register(selector, <modes.ISuggestSupport>{
triggerCharacters: triggerCharacters,
shouldAutotriggerSuggest: true,
suggest: (resource: URI, position: IPosition, triggerCharacter?: string): TPromise<modes.ISuggestResult[]> => {
return this._proxy.$suggest(handle, resource, position);
provideCompletionItems: (model:IReadOnlyModel, position:IEditorPosition, cancellationToken:CancellationToken): Thenable<modes.ISuggestResult[]> => {
return wireCancellationToken(cancellationToken, this._proxy.$suggest(handle, model.getAssociatedResource(), position));
},
getSuggestionDetails: (resource: URI, position: IPosition, suggestion: modes.ISuggestion): TPromise<modes.ISuggestion> => {
return this._proxy.$getSuggestionDetails(handle, resource, position, suggestion);