Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2025-12-24 04:09:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Handle some edge cases of #18131

Browse Source
This commit is contained in:
Matt Bierner
2019-01-28 14:23:26 -08:00
parent 807759ecff
commit b15877def6
1 changed files with 12 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
extensions/typescript-language-features/src/features/completions.ts
View File

@@ -638,25 +638,23 @@ class TypeScriptCompletionItemProvider implements vscode.CompletionItemProvider
try {
const args: Proto.FileLocationRequestArgs = typeConverters.Position.toFileLocationRequestArgs(filepath, position);
const response = await this.client.execute('quickinfo', args, token);
if (response.type !== 'response' || !response.body) {
return true;
if (response.type === 'response' && response.body) {
switch (response.body.kind) {
case 'var':
case 'let':
case 'const':
case 'alias':
return false;
}
}
switch (response.body.kind) {
case 'var':
case 'let':
case 'const':
case 'alias':
return false;
}
} catch (e) {
return true;
} catch {
// Noop
}
// Don't complete function call if there is already something that looks like a funciton call
// Don't complete function call if there is already something that looks like a function call
// https://github.com/Microsoft/vscode/issues/18131
const after = document.lineAt(position.line).text.slice(position.character);
return after.match(/^\s*\(/g) === null;
return after.match(/^[a-z_$0-9]*\s*\(/gi) === null;
}
}