Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-03 15:01:57 +01:00
Code Issues Packages Projects Releases Wiki Activity

Don't include dom typings in extensions (#89942)

Browse Source 
**Problem**
All of our extensions currently are built using the dom typings. This can lead to runtime errors if you mistakenly use `window` or similar

**Fix**
Exclude the dom typings from compile. Then explicitly import the node types for `URL` and `TextEncoder`
This commit is contained in:
Matt Bierner
2020-02-04 11:08:22 -08:00
committed by GitHub
parent a861520a49
commit b1c5e2f19b
4 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
extensions/vscode-api-tests/src/extension.ts
View File

@@ -13,10 +13,14 @@
//
import * as vscode from 'vscode';
import { URL } from 'url';
import { TextEncoder, TextDecoder } from 'util';
const textEncoder = new TextEncoder();
const SCHEME = 'memfs';
declare const window: unknown;
export function activate(context: vscode.ExtensionContext) {
if (typeof window !== 'undefined') { // do not run under node.js
const memFs = enableFs(context);