From b1e37822fb3ade6fbe37a9ca469ccf4eb4f292fe Mon Sep 17 00:00:00 2001 From: Johannes Rieken Date: Wed, 8 Oct 2025 18:10:41 +0200 Subject: [PATCH] fix `hideOnRequest` mode so that it doesn't show the inline chat for "good" responses (#270386) Looks like `ChatResponse#onDidChange` fires with a modified response array after completion... --- .../contrib/inlineChat/browser/inlineChatController.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/vs/workbench/contrib/inlineChat/browser/inlineChatController.ts b/src/vs/workbench/contrib/inlineChat/browser/inlineChatController.ts index eb42a9bde57..e9d5aa5d6a1 100644 --- a/src/vs/workbench/contrib/inlineChat/browser/inlineChatController.ts +++ b/src/vs/workbench/contrib/inlineChat/browser/inlineChatController.ts @@ -1417,6 +1417,8 @@ export class InlineChatController2 implements IEditorContribution { return; } + responseListener.value = undefined; // listen only ONCE + const shouldShow = response.isCanceled // cancelled || response.result?.errorDetails // errors || !response.response.value.find(part => part.kind === 'textEditGroup'