Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-21 17:19:01 +01:00
Code Issues Packages Projects Releases Wiki Activity

add preloads to notebook controller, fyi @connor4312 NotebookKernel will go out soon

Browse Source
This commit is contained in:
Johannes Rieken
2021-04-15 16:44:43 +02:00
parent c079d216f0
commit b2103c79e4
3 changed files with 30 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/vs/workbench/api/common/extHostNotebookKernels.ts
View File

@@ -11,7 +11,7 @@ import { ExtHostNotebookController } from 'vs/workbench/api/common/extHostNotebo
import { IExtensionDescription } from 'vs/platform/extensions/common/extensions';
import { URI, UriComponents } from 'vs/base/common/uri';
import { ICellRange } from 'vs/workbench/contrib/notebook/common/notebookCommon';
import { NotebookCellRange } from 'vs/workbench/api/common/extHostTypeConverters';
import * as extHostTypeConverters from 'vs/workbench/api/common/extHostTypeConverters';
import { isNonEmptyArray } from 'vs/base/common/arrays';
type ExecuteHandler = (cells: vscode.NotebookCell[], controller: vscode.NotebookController) => void;
@@ -105,6 +105,13 @@ export class ExtHostNotebookKernels implements ExtHostNotebookKernelsShape {
data.hasExecutionOrder = value;
_update();
},
get preloads() {
return data.preloads && data.preloads.map(extHostTypeConverters.NotebookKernelPreload.to);
},
set preloads(value) {
data.preloads = value && value.map(extHostTypeConverters.NotebookKernelPreload.from);
_update();
},
get executeHandler() {
return _executeHandler;
},
@@ -118,7 +125,7 @@ export class ExtHostNotebookKernels implements ExtHostNotebookKernelsShape {
},
createNotebookCellExecutionTask(cell) {
if (isDisposed) {
throw new Error('object disposed');
throw new Error('notebook controller is DISPOSED');
}
//todo@jrieken
return that._extHostNotebook.createNotebookCellExecution(cell.notebook.uri, cell.index, data.id)!;
@@ -166,7 +173,7 @@ export class ExtHostNotebookKernels implements ExtHostNotebookKernelsShape {
const cells: vscode.NotebookCell[] = [];
for (let range of ranges) {
cells.push(...document.notebookDocument.getCells(NotebookCellRange.to(range)));
cells.push(...document.notebookDocument.getCells(extHostTypeConverters.NotebookCellRange.to(range)));
}
try {