From b21350fdcbf276d98a55898a455e4baea67b5643 Mon Sep 17 00:00:00 2001 From: Matt Bierner Date: Tue, 29 Mar 2022 11:42:00 -0700 Subject: [PATCH] Use string uri as key instead of `fsPath` --- .../src/languageFeatures/workspaceSymbolProvider.ts | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/extensions/markdown-language-features/src/languageFeatures/workspaceSymbolProvider.ts b/extensions/markdown-language-features/src/languageFeatures/workspaceSymbolProvider.ts index 7bf2d11b60a..e016e9a87d4 100644 --- a/extensions/markdown-language-features/src/languageFeatures/workspaceSymbolProvider.ts +++ b/extensions/markdown-language-features/src/languageFeatures/workspaceSymbolProvider.ts @@ -129,7 +129,8 @@ class VSCodeWorkspaceMarkdownDocumentProvider extends Disposable implements Work } export default class MarkdownWorkspaceSymbolProvider extends Disposable implements vscode.WorkspaceSymbolProvider { - private _symbolCache = new Map>>(); + + private readonly _symbolCache = new Map>>(); private _symbolCachePopulated: boolean = false; public constructor( @@ -157,21 +158,21 @@ export default class MarkdownWorkspaceSymbolProvider extends Disposable implemen public async populateSymbolCache(): Promise { const markdownDocumentUris = await this._workspaceMarkdownDocumentProvider.getAllMarkdownDocuments(); for (const document of markdownDocumentUris) { - this._symbolCache.set(document.uri.fsPath, this.getSymbols(document)); + this._symbolCache.set(document.uri.toString(), this.getSymbols(document)); } } private getSymbols(document: SkinnyTextDocument): Lazy> { - return lazy(async () => { + return lazy(() => { return this._symbolProvider.provideDocumentSymbolInformation(document); }); } private onDidChangeDocument(document: SkinnyTextDocument) { - this._symbolCache.set(document.uri.fsPath, this.getSymbols(document)); + this._symbolCache.set(document.uri.toString(), this.getSymbols(document)); } private onDidDeleteDocument(resource: vscode.Uri) { - this._symbolCache.delete(resource.fsPath); + this._symbolCache.delete(resource.toString()); } }