From b22bd4778f03e3382fda585ab5dc18bb5ce7724d Mon Sep 17 00:00:00 2001 From: Sandeep Somavarapu Date: Tue, 21 Nov 2017 16:04:46 +0100 Subject: [PATCH] fix tests --- src/vs/platform/commands/test/commandService.test.ts | 2 +- .../extensionsWorkbenchService.test.ts | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/vs/platform/commands/test/commandService.test.ts b/src/vs/platform/commands/test/commandService.test.ts index 6a3000d94bc..4d262f8b2d8 100644 --- a/src/vs/platform/commands/test/commandService.test.ts +++ b/src/vs/platform/commands/test/commandService.test.ts @@ -118,7 +118,7 @@ suite('CommandService', function () { // let reg = CommandsRegistry.registerCommand('bar', () => callCounter += 1); let service = new CommandService(new InstantiationService(), new class extends SimpleExtensionService { - onReady() { + whenInstalledExtensionsRegistered() { return new TPromise(_resolve => { resolveFunc = _resolve; }); } }, new ContextKeyService(new SimpleConfigurationService())); diff --git a/src/vs/workbench/parts/extensions/test/electron-browser/extensionsWorkbenchService.test.ts b/src/vs/workbench/parts/extensions/test/electron-browser/extensionsWorkbenchService.test.ts index 1010b6185d3..4808ef0cf07 100644 --- a/src/vs/workbench/parts/extensions/test/electron-browser/extensionsWorkbenchService.test.ts +++ b/src/vs/workbench/parts/extensions/test/electron-browser/extensionsWorkbenchService.test.ts @@ -465,7 +465,7 @@ suite('ExtensionsWorkbenchService Test', () => { test('test one level extension dependencies without cycle', () => { testObject = instantiationService.createInstance(ExtensionsWorkbenchService); instantiationService.stubPromise(IExtensionGalleryService, 'query', aPage(aGalleryExtension('a', {}, { dependencies: ['pub.b', 'pub.c', 'pub.d'] }))); - instantiationService.stubPromise(IExtensionGalleryService, 'getAllDependencies', [aGalleryExtension('b'), aGalleryExtension('c'), aGalleryExtension('d')]); + instantiationService.stubPromise(IExtensionGalleryService, 'loadAllDependencies', [aGalleryExtension('b'), aGalleryExtension('c'), aGalleryExtension('d')]); return testObject.queryGallery().then(page => { const extension = page.firstPage[0]; @@ -504,7 +504,7 @@ suite('ExtensionsWorkbenchService Test', () => { test('test one level extension dependencies with cycle', () => { testObject = instantiationService.createInstance(ExtensionsWorkbenchService); instantiationService.stubPromise(IExtensionGalleryService, 'query', aPage(aGalleryExtension('a', {}, { dependencies: ['pub.b', 'pub.a'] }))); - instantiationService.stubPromise(IExtensionGalleryService, 'getAllDependencies', [aGalleryExtension('b'), aGalleryExtension('a')]); + instantiationService.stubPromise(IExtensionGalleryService, 'loadAllDependencies', [aGalleryExtension('b'), aGalleryExtension('a')]); return testObject.queryGallery().then(page => { const extension = page.firstPage[0]; @@ -536,7 +536,7 @@ suite('ExtensionsWorkbenchService Test', () => { test('test one level extension dependencies with missing dependencies', () => { testObject = instantiationService.createInstance(ExtensionsWorkbenchService); instantiationService.stubPromise(IExtensionGalleryService, 'query', aPage(aGalleryExtension('a', {}, { dependencies: ['pub.b', 'pub.a'] }))); - instantiationService.stubPromise(IExtensionGalleryService, 'getAllDependencies', [aGalleryExtension('a')]); + instantiationService.stubPromise(IExtensionGalleryService, 'loadAllDependencies', [aGalleryExtension('a')]); return testObject.queryGallery().then(page => { const extension = page.firstPage[0]; @@ -570,7 +570,7 @@ suite('ExtensionsWorkbenchService Test', () => { instantiationService.stubPromise(IExtensionManagementService, 'getInstalled', [local]); testObject = instantiationService.createInstance(ExtensionsWorkbenchService); instantiationService.stubPromise(IExtensionGalleryService, 'query', aPage(aGalleryExtension('a', {}, { dependencies: ['pub.inbuilt', 'pub.a'] }))); - instantiationService.stubPromise(IExtensionGalleryService, 'getAllDependencies', [aGalleryExtension('a')]); + instantiationService.stubPromise(IExtensionGalleryService, 'loadAllDependencies', [aGalleryExtension('a')]); return testObject.queryGallery().then(page => { const extension = page.firstPage[0]; @@ -605,7 +605,7 @@ suite('ExtensionsWorkbenchService Test', () => { instantiationService.stubPromise(IExtensionManagementService, 'getInstalled', [local]); testObject = instantiationService.createInstance(ExtensionsWorkbenchService); instantiationService.stubPromise(IExtensionGalleryService, 'query', aPage(aGalleryExtension('a', {}, { dependencies: ['pub.b', 'pub.c'] }))); - instantiationService.stubPromise(IExtensionGalleryService, 'getAllDependencies', [ + instantiationService.stubPromise(IExtensionGalleryService, 'loadAllDependencies', [ aGalleryExtension('b', {}, { dependencies: ['pub.d', 'pub.e'] }), aGalleryExtension('d', {}, { dependencies: ['pub.f', 'pub.c'] }), aGalleryExtension('e')]);