Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-27 20:13:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

fixes #139 - don't sync large models to extension host

Browse Source
This commit is contained in:
Alex Dima
2015-11-25 13:54:16 +01:00
parent b57564d7fb
commit b255288e3b
2 changed files with 18 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/vs/workbench/api/common/mainThreadEditors.ts
View File

@@ -335,6 +335,8 @@ export class MainThreadEditorsTracker {
private _doUpdateMapping(): void {
let allModels = this._modelService.getModels();
// Same filter as in pluginHostDocuments
allModels.filter((model) => !model.isTooLargeForHavingARichMode());
let allModelsMap: { [modelUri:string]: EditorCommon.IModel; } = Object.create(null);
allModels.forEach((model) => {
allModelsMap[model.getAssociatedResource().toString()] = model;

16
src/vs/workbench/api/common/pluginHostDocuments.ts
View File

@@ -532,6 +532,7 @@ export class MainThreadDocuments {
private _toDispose: IDisposable[];
private _modelToDisposeMap: {[modelUrl:string]:IDisposable;};
private _proxy: PluginHostModelService;
private _modelIsSynced: {[modelId:string]:boolean;};
constructor(
@IThreadService threadService: IThreadService,
@@ -547,6 +548,7 @@ export class MainThreadDocuments {
this._fileService = fileService;
this._untitledEditorService = untitledEditorService;
this._proxy = threadService.getRemotable(PluginHostModelService);
this._modelIsSynced = {};
this._toDispose = [];
modelService.onModelAdded.add(this._onModelAdded, this, this._toDispose);
@@ -575,7 +577,13 @@ export class MainThreadDocuments {
}
private _onModelAdded(model: EditorCommon.IModel): void {
// Same filter as in mainThreadEditors
if (model.isTooLargeForHavingARichMode()) {
// don't synchronize too large models
return null;
}
let modelUrl = model.getAssociatedResource();
this._modelIsSynced[modelUrl.toString()] = true;
this._modelToDisposeMap[modelUrl.toString()] = model.addBulkListener2((events) => this._onModelEvents(modelUrl, events));
this._proxy._acceptModelAdd({
url: model.getAssociatedResource(),
@@ -587,11 +595,19 @@ export class MainThreadDocuments {
}
private _onModelModeChanged(model: EditorCommon.IModel, oldModeId:string): void {
let modelUrl = model.getAssociatedResource();
if (!this._modelIsSynced[modelUrl.toString()]) {
return;
}
this._proxy._acceptModelModeChanged(model.getAssociatedResource(), oldModeId, model.getMode().getId());
}
private _onModelRemoved(model: EditorCommon.IModel): void {
let modelUrl = model.getAssociatedResource();
if (!this._modelIsSynced[modelUrl.toString()]) {
return;
}
delete this._modelIsSynced[modelUrl.toString()];
this._modelToDisposeMap[modelUrl.toString()].dispose();
delete this._modelToDisposeMap[modelUrl.toString()];
this._proxy._acceptModelRemoved(modelUrl);