Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-21 17:19:01 +01:00
Code Issues Packages Projects Releases Wiki Activity

smoke - improve app lifecycle (#139693)

Browse Source 
* smoke - make sure app is closed when `app.start` fails

* smoke - `capturePage` to fallback to active window

* smoke - more logging around remote resolving
This commit is contained in:
Benjamin Pasero
2021-12-23 16:38:54 +01:00
committed by GitHub
parent d89b167121
commit b2e79a699f
6 changed files with 39 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
test/smoke/src/utils.ts
View File

@@ -88,7 +88,8 @@ export function installDiagnosticsHandler(logger: Logger, appFn?: () => Applicat
function installAppBeforeHandler(optionsTransform?: (opts: ApplicationOptions) => ApplicationOptions) {
before(async function () {
this.app = await startApp(this.defaultOptions, optionsTransform);
this.app = createApp(this.defaultOptions, optionsTransform);
await this.app.start();
});
}
@@ -105,7 +106,7 @@ export function installAppAfterHandler(appFn?: () => Application | undefined, jo
});
}
export async function startApp(options: ApplicationOptions, optionsTransform?: (opts: ApplicationOptions) => ApplicationOptions): Promise<Application> {
export function createApp(options: ApplicationOptions, optionsTransform?: (opts: ApplicationOptions) => ApplicationOptions): Application {
if (optionsTransform) {
options = optionsTransform({ ...options });
}
@@ -115,8 +116,6 @@ export async function startApp(options: ApplicationOptions, optionsTransform?: (
userDataDir: getRandomUserDataDir(options)
});
await app.start();
return app;
}