Replace some common index based for loops with for-of loops

Replaces many loops of the form:

```js
for (let i = 0; i < elements.length; ++i) {
    const i = elements[i];
   ...
}
```

with:

```js
for (const element of elements) {
    ...
}
```

Mix of a horrible regex based find/replace and manual touch ups

src/vs/code/node/windowsFinder.ts

@@ -43,8 +43,7 @@ function findWindowOnFilePath<W extends ISimpleWindow>(windows: W[], fileUri: UR
 
 	// First check for windows with workspaces that have a parent folder of the provided path opened
 	const workspaceWindows = windows.filter(window => !!window.openedWorkspace);
-	for (let i = 0; i < workspaceWindows.length; i++) {
-		const window = workspaceWindows[i];
+	for (const window of workspaceWindows) {
 		const resolvedWorkspace = workspaceResolver(window.openedWorkspace!);
 		if (resolvedWorkspace && resolvedWorkspace.folders.some(folder => isEqualOrParent(fileUri, folder.uri))) {
 			return window;