Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-21 00:59:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

add cancellation to NotebookSerializer, https://github.com/microsoft/vscode/issues/121329

Browse Source
This commit is contained in:
Johannes Rieken
2021-04-15 16:21:06 +02:00
parent afa4a2df2c
commit b6cee1ca22
4 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/vs/workbench/api/common/extHostNotebook.ts
View File

@@ -567,19 +567,19 @@ export class ExtHostNotebookController implements ExtHostNotebookShape {
});
}
async $dataToNotebook(handle: number, bytes: VSBuffer): Promise<NotebookDataDto> {
async $dataToNotebook(handle: number, bytes: VSBuffer, token: CancellationToken): Promise<NotebookDataDto> {
const serializer = this._notebookSerializer.get(handle);
if (!serializer) {
throw new Error('NO serializer found');
}
const data = await serializer.deserializeNotebook(bytes.buffer);
const data = await serializer.deserializeNotebook(bytes.buffer, token);
return {
metadata: typeConverters.NotebookDocumentMetadata.from(data.metadata),
cells: data.cells.map(typeConverters.NotebookCellData.from),
};
}
async $notebookToData(handle: number, data: NotebookDataDto): Promise<VSBuffer> {
async $notebookToData(handle: number, data: NotebookDataDto, token: CancellationToken): Promise<VSBuffer> {
const serializer = this._notebookSerializer.get(handle);
if (!serializer) {
throw new Error('NO serializer found');
@@ -587,7 +587,7 @@ export class ExtHostNotebookController implements ExtHostNotebookShape {
const bytes = await serializer.serializeNotebook({
metadata: typeConverters.NotebookDocumentMetadata.to(data.metadata),
cells: data.cells.map(typeConverters.NotebookCellData.to)
});
}, token);
return VSBuffer.wrap(bytes);
}