Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-19 16:18:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix arguments for create tsconfig/jsconfig (#224990)

Browse Source 
Fix arguments for create tsconfig/jsconfig

Fixes #224989

Adds typings too to prevent this again
This commit is contained in:
Matt Bierner
2024-08-06 16:04:21 -07:00
committed by GitHub
parent cd340e6aa4
commit b7e421b734
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
extensions/typescript-language-features/src/ui/intellisenseStatus.ts
View File

@@ -43,6 +43,8 @@ namespace IntellisenseState {
export type State = typeof None | Pending | Resolved | typeof SyntaxOnly;
}
type CreateOrOpenConfigCommandArgs = [root: vscode.Uri, projectType: ProjectType];
export class IntellisenseStatus extends Disposable {
public readonly openOpenConfigCommandId = '_typescript.openConfig';
@@ -62,7 +64,7 @@ export class IntellisenseStatus extends Disposable {
commandManager.register({
id: this.openOpenConfigCommandId,
execute: async (root: vscode.Uri, projectType: ProjectType) => {
execute: async (...[root, projectType]: CreateOrOpenConfigCommandArgs) => {
if (this._state.type === IntellisenseState.Type.Resolved) {
await openProjectConfigOrPromptToCreate(projectType, this._client, root, this._state.configFile);
} else if (this._state.type === IntellisenseState.Type.Pending) {
@@ -72,7 +74,7 @@ export class IntellisenseStatus extends Disposable {
});
commandManager.register({
id: this.createOrOpenConfigCommandId,
execute: async (root: vscode.Uri, projectType: ProjectType) => {
execute: async (...[root, projectType]: CreateOrOpenConfigCommandArgs) => {
await openOrCreateConfig(this._client.apiVersion, projectType, root, this._client.configuration);
},
});
@@ -182,7 +184,7 @@ export class IntellisenseStatus extends Disposable {
title: this._state.projectType === ProjectType.TypeScript
? vscode.l10n.t("Configure tsconfig")
: vscode.l10n.t("Configure jsconfig"),
arguments: [rootPath],
arguments: [rootPath, this._state.projectType] satisfies CreateOrOpenConfigCommandArgs,
};
} else {
statusItem.text = vscode.workspace.asRelativePath(this._state.configFile);
@@ -190,7 +192,7 @@ export class IntellisenseStatus extends Disposable {
statusItem.command = {
command: this.openOpenConfigCommandId,
title: vscode.l10n.t("Open config file"),
arguments: [rootPath],
arguments: [rootPath, this._state.projectType] satisfies CreateOrOpenConfigCommandArgs,
};
}
break;