From b8667fa1073f00a157aa22f70b7ceaec276d96f6 Mon Sep 17 00:00:00 2001 From: Miguel Solorio Date: Thu, 2 Jan 2020 14:13:16 -0800 Subject: [PATCH] Update paremeter hint chevrons (ref #86708) --- .../contrib/parameterHints/arrow-down-dark.svg | 1 - .../contrib/parameterHints/arrow-down.svg | 1 - .../contrib/parameterHints/arrow-up-dark.svg | 1 - .../editor/contrib/parameterHints/arrow-up.svg | 1 - .../contrib/parameterHints/parameterHints.css | 18 +----------------- .../parameterHints/parameterHintsWidget.ts | 4 ++-- 6 files changed, 3 insertions(+), 23 deletions(-) delete mode 100644 src/vs/editor/contrib/parameterHints/arrow-down-dark.svg delete mode 100644 src/vs/editor/contrib/parameterHints/arrow-down.svg delete mode 100644 src/vs/editor/contrib/parameterHints/arrow-up-dark.svg delete mode 100644 src/vs/editor/contrib/parameterHints/arrow-up.svg diff --git a/src/vs/editor/contrib/parameterHints/arrow-down-dark.svg b/src/vs/editor/contrib/parameterHints/arrow-down-dark.svg deleted file mode 100644 index b1a76d789ea..00000000000 --- a/src/vs/editor/contrib/parameterHints/arrow-down-dark.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/src/vs/editor/contrib/parameterHints/arrow-down.svg b/src/vs/editor/contrib/parameterHints/arrow-down.svg deleted file mode 100644 index d643403d75b..00000000000 --- a/src/vs/editor/contrib/parameterHints/arrow-down.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/src/vs/editor/contrib/parameterHints/arrow-up-dark.svg b/src/vs/editor/contrib/parameterHints/arrow-up-dark.svg deleted file mode 100644 index 43f31a09521..00000000000 --- a/src/vs/editor/contrib/parameterHints/arrow-up-dark.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/src/vs/editor/contrib/parameterHints/arrow-up.svg b/src/vs/editor/contrib/parameterHints/arrow-up.svg deleted file mode 100644 index b8072bb31bb..00000000000 --- a/src/vs/editor/contrib/parameterHints/arrow-up.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/src/vs/editor/contrib/parameterHints/parameterHints.css b/src/vs/editor/contrib/parameterHints/parameterHints.css index 13888e672b2..aa7ba057b9d 100644 --- a/src/vs/editor/contrib/parameterHints/parameterHints.css +++ b/src/vs/editor/contrib/parameterHints/parameterHints.css @@ -89,11 +89,7 @@ .monaco-editor .parameter-hints-widget .button.previous { bottom: 24px; - background-image: url('arrow-up.svg'); -} - -.monaco-editor .parameter-hints-widget .button.next { - background-image: url('arrow-down.svg'); + /* background-image: url('arrow-up.svg'); */ } .monaco-editor .parameter-hints-widget .overloads { @@ -113,15 +109,3 @@ font-weight: bold; margin-right: 0.5em; } - -/*** VS Dark & High Contrast*/ - -.monaco-editor.hc-black .parameter-hints-widget .button.previous, -.monaco-editor.vs-dark .parameter-hints-widget .button.previous { - background-image: url('arrow-up-dark.svg'); -} - -.monaco-editor.hc-black .parameter-hints-widget .button.next, -.monaco-editor.vs-dark .parameter-hints-widget .button.next { - background-image: url('arrow-down-dark.svg'); -} diff --git a/src/vs/editor/contrib/parameterHints/parameterHintsWidget.ts b/src/vs/editor/contrib/parameterHints/parameterHintsWidget.ts index 2120dc7aac8..41e4a66fd1d 100644 --- a/src/vs/editor/contrib/parameterHints/parameterHintsWidget.ts +++ b/src/vs/editor/contrib/parameterHints/parameterHintsWidget.ts @@ -78,9 +78,9 @@ export class ParameterHintsWidget extends Disposable implements IContentWidget { wrapper.tabIndex = -1; const controls = dom.append(wrapper, $('.controls')); - const previous = dom.append(controls, $('.button.previous')); + const previous = dom.append(controls, $('.button.codicon.codicon-chevron-up')); const overloads = dom.append(controls, $('.overloads')); - const next = dom.append(controls, $('.button.next')); + const next = dom.append(controls, $('.button.codicon.codicon-chevron-down')); const onPreviousClick = stop(domEvent(previous, 'click')); this._register(onPreviousClick(this.previous, this));