From b956dfa71937bb6e471fc96cddcb9a0ed55b5788 Mon Sep 17 00:00:00 2001 From: dileepyavan <52841896+dileepyavan@users.noreply.github.com> Date: Sun, 29 Mar 2026 23:47:33 -0700 Subject: [PATCH] Update src/vs/workbench/contrib/terminalContrib/chatAgentTools/common/terminalSandboxService.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- .../chatAgentTools/common/terminalSandboxService.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/terminalContrib/chatAgentTools/common/terminalSandboxService.ts b/src/vs/workbench/contrib/terminalContrib/chatAgentTools/common/terminalSandboxService.ts index 596b98e1410..31c32c6b2c5 100644 --- a/src/vs/workbench/contrib/terminalContrib/chatAgentTools/common/terminalSandboxService.ts +++ b/src/vs/workbench/contrib/terminalContrib/chatAgentTools/common/terminalSandboxService.ts @@ -742,7 +742,10 @@ export class TerminalSandboxService extends Disposable implements ITerminalSandb const setting = this._configurationService.inspect(settingId); const deprecatedSetting = deprecatedSettingId ? this._configurationService.inspect(deprecatedSettingId) : undefined; - if (setting.userValue === undefined && deprecatedSetting?.userValue !== undefined) { + const isSettingConfigured = setting.value !== setting.defaultValue; + const isDeprecatedSettingConfigured = deprecatedSetting !== undefined && deprecatedSetting.value !== deprecatedSetting.defaultValue; + + if (!isSettingConfigured && isDeprecatedSettingConfigured) { this._logService.warn(`TerminalSandboxService: Using deprecated setting ${deprecatedSettingId} because ${settingId} is not set. Please update your settings to use ${settingId} instead.`); return deprecatedSetting.value; }