don't pass model service to applyEdit but check model version for edit that come from extensions, fixes https://github.com/microsoft/vscode/issues/117683

This commit is contained in:
Johannes Rieken
2021-03-01 09:54:02 +01:00
parent 8fd4a68845
commit b99df4f2b6
10 changed files with 41 additions and 45 deletions

View File

@@ -160,7 +160,10 @@ export class MainThreadNotebooks extends Disposable implements MainThreadNoteboo
if (!textModel) {
return false;
}
return textModel.applyEdits(modelVersionId, cellEdits, true, undefined, () => undefined, undefined);
if (textModel.versionId !== modelVersionId) {
return false;
}
return textModel.applyEdits(cellEdits, true, undefined, () => undefined, undefined);
}
private _isDeltaEmpty(delta: INotebookDocumentsAndEditorsDelta) {