Strict null work in exthost

src/vs/workbench/api/node/extHostCLIServer.ts

@@ -39,7 +39,7 @@ export class CLIServer {
 			console.error('Could not start open from terminal server.');
 		}
 
-		return this.ipcHandlePath;
+		return this._ipcHandlePath;
 	}
 	private collectURIToOpen(strs: string[], typeHint: URIType, result: IURIToOpen[]): void {
 		if (Array.isArray(strs)) {

src/vs/workbench/api/node/extHostCommands.ts

@@ -22,7 +22,7 @@ import { URI } from 'vs/base/common/uri';
 interface CommandHandler {
 	callback: Function;
 	thisArg: any;
-	description: ICommandHandlerDescription;
+	description?: ICommandHandlerDescription;
 }
 
 export interface ArgumentProcessor {

src/vs/workbench/api/node/extHostDocumentSaveParticipant.ts

@@ -60,7 +60,7 @@ export class ExtHostDocumentSaveParticipant implements ExtHostDocumentSavePartic
 
 				if (didTimeout) {
 					// timeout - no more listeners
-					return undefined;
+					return Promise.resolve();
 				}
 
 				const document = this._documents.getDocument(resource);

src/vs/workbench/api/node/extHostTextEditors.ts

@@ -97,6 +97,9 @@ export class ExtHostEditors implements ExtHostEditorsShape {
 
 	$acceptEditorPropertiesChanged(id: string, data: IEditorPropertiesChangeData): void {
 		const textEditor = this._extHostDocumentsAndEditors.getEditor(id);
+		if (!textEditor) {
+			throw new Error('unknown text editor');
+		}
 
 		// (1) set all properties
 		if (data.options) {
@@ -137,9 +140,12 @@ export class ExtHostEditors implements ExtHostEditorsShape {
 	}
 
 	$acceptEditorPositionData(data: ITextEditorPositionData): void {
-		for (let id in data) {
-			let textEditor = this._extHostDocumentsAndEditors.getEditor(id);
-			let viewColumn = TypeConverters.ViewColumn.to(data[id]);
+		for (const id in data) {
+			const textEditor = this._extHostDocumentsAndEditors.getEditor(id);
+			if (!textEditor) {
+				throw new Error('Unknown text editor');
+			}
+			const viewColumn = TypeConverters.ViewColumn.to(data[id]);
 			if (textEditor.viewColumn !== viewColumn) {
 				textEditor._acceptViewColumn(viewColumn);
 				this._onDidChangeTextEditorViewColumn.fire({ textEditor, viewColumn });