Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-19 16:18:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

Manage ChatModels with ref-counting, allow running in bg (#278476)

Browse Source 
* Manage ChatModels with ref-counting, allow running in bg
Towards #277318

* Rename

* Clear widget viewmodel when editor is closed

* Cleanups

* Comment

* cleanup

* Ensure models disposed

* Revert file

* Fix tests
This commit is contained in:
Rob Lourens
2025-11-20 21:24:50 -08:00
committed by GitHub
parent 0b951cc941
commit bbdd097bd3
16 changed files with 390 additions and 189 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/vs/workbench/contrib/inlineChat/browser/inlineChatController.ts
View File

@@ -51,7 +51,7 @@ import { IChatAttachmentResolveService } from '../../chat/browser/chatAttachment
import { IChatWidgetLocationOptions } from '../../chat/browser/chatWidget.js';
import { ChatContextKeys } from '../../chat/common/chatContextKeys.js';
import { IChatEditingSession, ModifiedFileEntryState } from '../../chat/common/chatEditingService.js';
import { ChatRequestRemovalReason, IChatRequestModel, IChatTextEditGroup, IChatTextEditGroupState, IResponse } from '../../chat/common/chatModel.js';
import { ChatModel, ChatRequestRemovalReason, IChatRequestModel, IChatTextEditGroup, IChatTextEditGroupState, IResponse } from '../../chat/common/chatModel.js';
import { ChatMode } from '../../chat/common/chatModes.js';
import { IChatService } from '../../chat/common/chatService.js';
import { IChatRequestVariableEntry, IDiagnosticVariableEntryFilterData } from '../../chat/common/chatVariableEntries.js';
@@ -1587,12 +1587,13 @@ export async function reviewEdits(accessor: ServicesAccessor, editor: ICodeEdito
const chatService = accessor.get(IChatService);
const uri = editor.getModel().uri;
const chatModel = chatService.startSession(ChatAgentLocation.EditorInline, token);
const chatModelRef = chatService.startSession(ChatAgentLocation.EditorInline, token);
const chatModel = chatModelRef.object as ChatModel;
chatModel.startEditingSession(true);
const store = new DisposableStore();
store.add(chatModel);
store.add(chatModelRef);
// STREAM
const chatRequest = chatModel?.addRequest({ text: '', parts: [] }, { variables: [] }, 0, {
@@ -1638,12 +1639,13 @@ export async function reviewNotebookEdits(accessor: ServicesAccessor, uri: URI,
const chatService = accessor.get(IChatService);
const notebookService = accessor.get(INotebookService);
const isNotebook = notebookService.hasSupportedNotebooks(uri);
const chatModel = chatService.startSession(ChatAgentLocation.EditorInline, token);
const chatModelRef = chatService.startSession(ChatAgentLocation.EditorInline, token);
const chatModel = chatModelRef.object as ChatModel;
chatModel.startEditingSession(true);
const store = new DisposableStore();
store.add(chatModel);
store.add(chatModelRef);
// STREAM
const chatRequest = chatModel?.addRequest({ text: '', parts: [] }, { variables: [] }, 0);