From bc0574de38d07f7183a0bd9e331f4b4a1131ea86 Mon Sep 17 00:00:00 2001 From: Andre Weinand Date: Thu, 21 Mar 2019 15:23:27 +0100 Subject: [PATCH] server-ready feature: better error msg when chome not installed --- .../debug-server-ready/src/extension.ts | 21 ++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/extensions/debug-server-ready/src/extension.ts b/extensions/debug-server-ready/src/extension.ts index 0ec7303cfc3..3edfcdc5031 100644 --- a/extensions/debug-server-ready/src/extension.ts +++ b/extensions/debug-server-ready/src/extension.ts @@ -136,13 +136,20 @@ class ServerReadyDetector extends vscode.Disposable { vscode.env.openExternal(vscode.Uri.parse(uri)); break; case 'debugWithChrome': - vscode.debug.startDebugging(session.workspaceFolder, { - type: 'chrome', - name: 'Chrome Debug', - request: 'launch', - url: uri, - webRoot: args.webRoot || WEB_ROOT - }, session); + + const chrome = vscode.extensions.getExtension('msjsdiag.debugger-for-chrome'); + if (chrome) { + vscode.debug.startDebugging(session.workspaceFolder, { + type: 'chrome', + name: 'Chrome Debug', + request: 'launch', + url: uri, + webRoot: args.webRoot || WEB_ROOT + }, session); + } else { + const errMsg = localize('server.ready.chrome.not.installed', "The action 'debugWithChrome' requires the '{0}'", 'Debugger for Chrome'); + vscode.window.showErrorMessage(errMsg, { modal: true }).then(_ => undefined); + } break; default: // not supported