Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-26 11:38:51 +01:00
Code Issues Packages Projects Releases Wiki Activity

Make sure CommentControl & CommentsProvider handles are unique.

Browse Source
This commit is contained in:
Peng Lyu
2019-02-22 11:02:23 -08:00
parent de52daea94
commit bcc48091d3
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/vs/workbench/api/node/extHostComments.ts
View File

@@ -76,7 +76,8 @@ export class ExtHostComments implements ExtHostCommentsShape {
}
createCommentControl(extension: IExtensionDescription, id: string, label: string): vscode.CommentControl {
const commentControl = new ExtHostCommentControl(extension, this._commands.converter, this._proxy, id, label);
const handle = ExtHostComments.handlePool++;
const commentControl = new ExtHostCommentControl(extension, handle, this._commands.converter, this._proxy, id, label);
this._commentControls.set(commentControl.handle, commentControl);
const commentControls = this._commentControlsByExtension.get(ExtensionIdentifier.toKey(extension.identifier)) || [];
@@ -383,8 +384,6 @@ export class ExtHostCommentWidget implements vscode.CommentWidget {
}
class ExtHostCommentControl implements vscode.CommentControl {
private static _handlePool: number = 0;
get id(): string {
return this._id;
}
@@ -395,11 +394,15 @@ class ExtHostCommentControl implements vscode.CommentControl {
public widget?: ExtHostCommentWidget;
public handle: number = ExtHostCommentControl._handlePool++;
public get handle(): number {
return this._handle;
}
private _threads: Map<number, ExtHostCommentThread> = new Map<number, ExtHostCommentThread>();
constructor(
_extension: IExtensionDescription,
private _handle: number,
private readonly _commandsConverter: CommandsConverter,
private _proxy: MainThreadCommentsShape,
private _id: string,