From bd673fa1e80ef01700f687c81290087bfbbef083 Mon Sep 17 00:00:00 2001 From: Johannes Date: Fri, 10 Apr 2026 16:58:37 +0200 Subject: [PATCH] Remove logging of unexpected approval needed in InlineChatSessionOverlayWidget --- .../inlineChat/browser/inlineChatOverlayWidget.ts | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/src/vs/workbench/contrib/inlineChat/browser/inlineChatOverlayWidget.ts b/src/vs/workbench/contrib/inlineChat/browser/inlineChatOverlayWidget.ts index e4ff3377e83..da9692cdf18 100644 --- a/src/vs/workbench/contrib/inlineChat/browser/inlineChatOverlayWidget.ts +++ b/src/vs/workbench/contrib/inlineChat/browser/inlineChatOverlayWidget.ts @@ -37,7 +37,6 @@ import { ChatEditingAcceptRejectActionViewItem } from '../../chat/browser/chatEd import { CTX_INLINE_CHAT_INPUT_HAS_TEXT, CTX_INLINE_CHAT_INPUT_WIDGET_FOCUSED } from '../common/inlineChat.js'; import { StickyScrollController } from '../../../../editor/contrib/stickyScroll/browser/stickyScrollController.js'; import { IKeybindingService } from '../../../../platform/keybinding/common/keybinding.js'; -import { ILogService } from '../../../../platform/log/common/log.js'; import { IConfigurationService } from '../../../../platform/configuration/common/configuration.js'; import { getSimpleEditorOptions } from '../../codeEditor/browser/simpleEditorOptions.js'; import { PlaceholderTextContribution } from '../../../../editor/contrib/placeholderText/browser/placeholderTextContribution.js'; @@ -446,20 +445,17 @@ export class InlineChatSessionOverlayWidget extends Disposable { readonly #editorObs: ObservableCodeEditor; readonly #instaService: IInstantiationService; readonly #keybindingService: IKeybindingService; - readonly #logService: ILogService; constructor( editorObs: ObservableCodeEditor, @IInstantiationService instaService: IInstantiationService, @IKeybindingService keybindingService: IKeybindingService, - @ILogService logService: ILogService, ) { super(); this.#editorObs = editorObs; this.#instaService = instaService; this.#keybindingService = keybindingService; - this.#logService = logService; this.#domNode.classList.add('inline-chat-session-overlay-widget'); @@ -609,15 +605,6 @@ export class InlineChatSessionOverlayWidget extends Disposable { } })); - // Log when pending confirmation changes - this.#showStore.add(autorun(r => { - const response = session.chatModel.lastRequestObs.read(r)?.response; - const pending = response?.isPendingConfirmation.read(r); - if (pending) { - this.#logService.info(`[InlineChat] UNEXPECTED approval needed: ${pending.detail ?? 'unknown'}`); - } - })); - // Add toolbar this.#contentRow.appendChild(this.#toolbarNode); this.#showStore.add(toDisposable(() => this.#toolbarNode.remove()));