Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2025-12-20 02:08:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: memory leak in terminal chat widget (#284325)

Browse Source
This commit is contained in:
Simon Siefke
2025-12-19 01:44:46 +03:00
committed by GitHub
parent 89b8c4e9fa
commit beecac5671
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/vs/workbench/contrib/terminalContrib/chat/browser/terminalChatWidget.ts
View File

@@ -8,7 +8,7 @@ import { Dimension, getActiveWindow, IFocusTracker, trackFocus } from '../../../
import { CancelablePromise, createCancelablePromise, DeferredPromise } from '../../../../../base/common/async.js'; import { CancelablePromise, createCancelablePromise, DeferredPromise } from '../../../../../base/common/async.js';
import { CancellationTokenSource } from '../../../../../base/common/cancellation.js'; import { CancellationTokenSource } from '../../../../../base/common/cancellation.js';
import { Emitter, Event } from '../../../../../base/common/event.js'; import { Emitter, Event } from '../../../../../base/common/event.js';
import { Disposable, DisposableStore, MutableDisposable, toDisposable } from '../../../../../base/common/lifecycle.js'; import { Disposable, DisposableStore, IDisposable, MutableDisposable, toDisposable } from '../../../../../base/common/lifecycle.js';
import { autorun, observableValue, type IObservable } from '../../../../../base/common/observable.js'; import { autorun, observableValue, type IObservable } from '../../../../../base/common/observable.js';
import { MicrotaskDelay } from '../../../../../base/common/symbols.js'; import { MicrotaskDelay } from '../../../../../base/common/symbols.js';
import { localize } from '../../../../../nls.js'; import { localize } from '../../../../../nls.js';
@@ -82,6 +82,7 @@ export class TerminalChatWidget extends Disposable {
private _terminalAgentName = 'terminal'; private _terminalAgentName = 'terminal';
private readonly _model: MutableDisposable<IChatModelReference> = this._register(new MutableDisposable()); private readonly _model: MutableDisposable<IChatModelReference> = this._register(new MutableDisposable());
private readonly _sessionDisposables: MutableDisposable<IDisposable> = this._register(new MutableDisposable());
private _sessionCtor: CancelablePromise<void> | undefined; private _sessionCtor: CancelablePromise<void> | undefined;
@@ -334,7 +335,7 @@ export class TerminalChatWidget extends Disposable {
this._resetPlaceholder(); this._resetPlaceholder();
} }
}); });
this._register(toDisposable(() => this._sessionCtor?.cancel())); this._sessionDisposables.value = toDisposable(() => this._sessionCtor?.cancel());
} }
private _saveViewState() { private _saveViewState() {