From bef3bfdbd4479eeedd96d1e2c79438261f1fbcac Mon Sep 17 00:00:00 2001 From: Dirk Baeumer Date: Wed, 5 Jul 2017 14:13:54 +0200 Subject: [PATCH] More deprecation --- .../tasks/electron-browser/jsonSchema_v2.ts | 21 +++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/src/vs/workbench/parts/tasks/electron-browser/jsonSchema_v2.ts b/src/vs/workbench/parts/tasks/electron-browser/jsonSchema_v2.ts index 3e1f9f25cb8..97f67f5732d 100644 --- a/src/vs/workbench/parts/tasks/electron-browser/jsonSchema_v2.ts +++ b/src/vs/workbench/parts/tasks/electron-browser/jsonSchema_v2.ts @@ -222,6 +222,10 @@ let taskDescription: IJSONSchema = definitions.taskDescription; taskDescription.properties.isShellCommand = Objects.deepClone(shellCommand); taskDescription.properties.dependsOn = dependsOn; taskDescription.properties.identifier = Objects.deepClone(identifier); +taskDescription.properties.type = Objects.deepClone(taskType); +taskDescription.properties.presentation = Objects.deepClone(presentation); +taskDescription.properties.terminal = terminal; +taskDescription.properties.group = Objects.deepClone(group); definitions.showOutputType.deprecationMessage = nls.localize( 'JsonSchema.tasks.showOputput.deprecated', 'The property showOutput is deprecated. Use the reveal property inside the presentation property instead. See also the 1.14 release notes.' @@ -230,6 +234,10 @@ definitions.taskDescription.properties.echoCommand.deprecationMessage = nls.loca 'JsonSchema.tasks.echoCommand.deprecated', 'The property echoCommand is deprecated. Use the echo property inside the presentation property instead. See also the 1.14 release notes.' ); +definitions.taskDescription.properties.suppressTaskName.deprecationMessage = nls.localize( + 'JsonSchema.tasks.suppressTaskName.deprecated', + 'The property suppressTaskName is deprecated. Inline the command with its arguments into the task instead. See also the 1.14 release notes.' +); definitions.taskDescription.properties.isBuildCommand.deprecationMessage = nls.localize( 'JsonSchema.tasks.isBuildCommand.deprecated', 'The property isBuildCommand is deprecated. Use the group property instead. See also the 1.14 release notes.' @@ -238,10 +246,6 @@ definitions.taskDescription.properties.isTestCommand.deprecationMessage = nls.lo 'JsonSchema.tasks.isTestCommand.deprecated', 'The property isTestCommand is deprecated. Use the group property instead. See also the 1.14 release notes.' ); -taskDescription.properties.type = Objects.deepClone(taskType); -taskDescription.properties.presentation = Objects.deepClone(presentation); -taskDescription.properties.terminal = terminal; -taskDescription.properties.group = Objects.deepClone(group); taskDefinitions.push({ $ref: '#/definitions/taskDescription' @@ -261,6 +265,15 @@ definitions.taskRunnerConfiguration.properties.isShellCommand = Objects.deepClon definitions.taskRunnerConfiguration.properties.type = Objects.deepClone(taskType); definitions.taskRunnerConfiguration.properties.group = Objects.deepClone(group); definitions.taskRunnerConfiguration.properties.presentation = Objects.deepClone(presentation); +definitions.taskRunnerConfiguration.properties.suppressTaskName.deprecationMessage = nls.localize( + 'JsonSchema.tasks.suppressTaskName.deprecated', + 'The property suppressTaskName is deprecated. Inline the command with its arguments into the task instead. See also the 1.14 release notes.' +); +definitions.taskRunnerConfiguration.properties.taskSelector.deprecationMessage = nls.localize( + 'JsonSchema.tasks.taskSelector.deprecated', + 'The property taskSelector is deprecated. Inline the command with its arguments into the task instead. See also the 1.14 release notes.' +); + let osSpecificTaskRunnerConfiguration = Objects.deepClone(definitions.taskRunnerConfiguration); delete osSpecificTaskRunnerConfiguration.properties.tasks; osSpecificTaskRunnerConfiguration.additionalProperties = false;