avoid more implicit any and some 💄

This commit is contained in:
Benjamin Pasero
2017-09-04 11:20:09 +02:00
parent 7712905526
commit bef497ff82
114 changed files with 282 additions and 296 deletions

View File

@@ -279,7 +279,7 @@ export interface MainThreadQuickOpenShape extends IDisposable {
export interface MainThreadStatusBarShape extends IDisposable {
$setEntry(id: number, extensionId: string, text: string, tooltip: string, command: string, color: string | ThemeColor, alignment: MainThreadStatusBarAlignment, priority: number): void;
$dispose(id: number);
$dispose(id: number): void;
}
export interface MainThreadStorageShape extends IDisposable {
@@ -298,7 +298,7 @@ export interface MainThreadWorkspaceShape extends IDisposable {
$applyWorkspaceEdit(edits: IResourceEdit[]): TPromise<boolean>;
$registerFileSystemProvider(handle: number, authority: string): void;
$unregisterFileSystemProvider(handle): void;
$unregisterFileSystemProvider(handle: number): void;
$onFileSystemChange(handle: number, resource: URI): void;
$updateSearchSession(session: number, data): void;
$finishSearchSession(session: number, err?: any): void;
@@ -379,7 +379,7 @@ export interface ExtHostCommandsShape {
}
export interface ExtHostConfigurationShape {
$acceptConfigurationChanged(data: IConfigurationData<any>);
$acceptConfigurationChanged(data: IConfigurationData<any>): void;
}
export interface ExtHostDiagnosticsShape {
@@ -461,7 +461,7 @@ export interface FileSystemEvents {
deleted: URI[];
}
export interface ExtHostFileSystemEventServiceShape {
$onFileEvent(events: FileSystemEvents);
$onFileEvent(events: FileSystemEvents): void;
}
export interface ObjectIdentifier {

View File

@@ -78,7 +78,7 @@ export class ExtHostDocumentData extends MirrorModel {
getText(range?) { return range ? data._getTextInRange(range) : data.getText(); },
get eol() { return data._eol === '\n' ? EndOfLine.LF : EndOfLine.CRLF; },
get lineCount() { return data._lines.length; },
lineAt(lineOrPos) { return data._lineAt(lineOrPos); },
lineAt(lineOrPos: number | vscode.Position) { return data._lineAt(lineOrPos); },
offsetAt(pos) { return data._offsetAt(pos); },
positionAt(offset) { return data._positionAt(offset); },
validateRange(ran) { return data._validateRange(ran); },

View File

@@ -342,7 +342,7 @@ export class ExtHostExtensionService implements ExtHostExtensionServiceShape {
if (typeof extensionModule.activate === 'function') {
try {
activationTimesBuilder.activateCallStart();
const activateResult = extensionModule.activate.apply(global, [context]);
const activateResult: TPromise<IExtensionAPI> = extensionModule.activate.apply(global, [context]);
activationTimesBuilder.activateCallStop();
activationTimesBuilder.activateResolveStart();

View File

@@ -874,7 +874,7 @@ export class ExtHostLanguageFeatures implements ExtHostLanguageFeaturesShape {
registerHoverProvider(selector: vscode.DocumentSelector, provider: vscode.HoverProvider, extensionId?: string): vscode.Disposable {
const handle = this._nextHandle();
this._adapter.set(handle, new HoverAdapter(this._documents, provider, once((name, data) => {
this._adapter.set(handle, new HoverAdapter(this._documents, provider, once((name: string, data: any) => {
data['extension'] = extensionId;
this._telemetry.$publicLog(name, data);
})));

View File

@@ -175,7 +175,7 @@ class ExtHostTreeView<T> extends Disposable {
};
}
private getLightIconPath(extensionTreeItem: vscode.TreeItem) {
private getLightIconPath(extensionTreeItem: vscode.TreeItem): string {
if (extensionTreeItem.iconPath) {
if (typeof extensionTreeItem.iconPath === 'string' || extensionTreeItem.iconPath instanceof URI) {
return this.getIconPath(extensionTreeItem.iconPath);
@@ -185,7 +185,7 @@ class ExtHostTreeView<T> extends Disposable {
return void 0;
}
private getDarkIconPath(extensionTreeItem: vscode.TreeItem) {
private getDarkIconPath(extensionTreeItem: vscode.TreeItem): string {
if (extensionTreeItem.iconPath && extensionTreeItem.iconPath['dark']) {
return this.getIconPath(extensionTreeItem.iconPath['dark']);
}