From befae3eaffeb27dff48b00a22587bfc2eac73a72 Mon Sep 17 00:00:00 2001
From: xingsy97 <87063252+xingsy97@users.noreply.github.com>
Date: Fri, 27 Mar 2026 14:10:14 +0800
Subject: [PATCH] timeline: fix memory leak when toggling pane visibility
 (#304668)

* timeline: dispose previous visibility subscriptions before recreating

* retrigger CI

---------

Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
---
 src/vs/workbench/contrib/timeline/browser/timelinePane.ts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/vs/workbench/contrib/timeline/browser/timelinePane.ts b/src/vs/workbench/contrib/timeline/browser/timelinePane.ts
index c7c9cc7f99b..7219c0991f1 100644
--- a/src/vs/workbench/contrib/timeline/browser/timelinePane.ts
+++ b/src/vs/workbench/contrib/timeline/browser/timelinePane.ts
@@ -883,6 +883,7 @@ export class TimelinePane extends ViewPane {
 	override setVisible(visible: boolean): void {
 		if (visible) {
 			this.extensionService.activateByEvent('onView:timeline');
+			this.visibilityDisposables?.dispose();
 			this.visibilityDisposables = new DisposableStore();
 
 			this.editorService.onDidActiveEditorChange(this.onActiveEditorChanged, this, this.visibilityDisposables);