Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-24 02:28:34 +01:00
Code Issues Packages Projects Releases Wiki Activity

Finalize Shell API (#243274)

Browse Source 
* Adopt terminal suggest to shell api change

* Internally bring string enum for terminal suggest to prevent Typos

* Better word description under api description

* Remove shell proposed api against vscode.d.ts

* Update `shell` description after looking at feedbacks.

* Update docs

* Change to a Map<TerminalShellTye, string[]>

* One last typo

---------

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
This commit is contained in:
Anthony Kim
2025-03-15 15:28:19 -07:00
committed by GitHub
parent 3e749796fa
commit bf36be9c61
7 changed files with 56 additions and 112 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
extensions/vscode-api-tests/src/singlefolder-tests/terminal.test.ts
View File

@@ -257,12 +257,12 @@ import { assertNoRpc, poll } from '../utils';
test('onDidChangeTerminalState should fire with shellType when created', async () => {
const terminal = window.createTerminal();
if (terminal.state.shellType) {
if (terminal.state.shell) {
return;
}
await new Promise<void>(r => {
disposables.push(window.onDidChangeTerminalState(e => {
if (e === terminal && e.state.shellType) {
if (e === terminal && e.state.shell) {
r();
}
}));