Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-22 17:48:56 +01:00
Code Issues Packages Projects Releases Wiki Activity

Get split terminals working

Browse Source
This commit is contained in:
Daniel Imms
2021-05-26 11:34:11 -07:00
parent 3ff91e7621
commit bf5f7dd5ec
6 changed files with 46 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/vs/workbench/api/node/extHostTerminalService.ts
View File

@@ -27,6 +27,7 @@ export class ExtHostTerminalService extends BaseExtHostTerminalService {
public createTerminalFromOptions(options: vscode.TerminalOptions, internalOptions?: ITerminalInternalOptions): vscode.Terminal {
const terminal = new ExtHostTerminal(this._proxy, generateUuid(), options, options.name);
this._terminals.push(terminal);
// TODO: Pass in options instead of individual props
terminal.create(
withNullAsUndefined(options.shellPath),
withNullAsUndefined(options.shellArgs),
@@ -39,7 +40,8 @@ export class ExtHostTerminalService extends BaseExtHostTerminalService {
withNullAsUndefined(options.hideFromUser),
withNullAsUndefined(internalOptions?.isFeatureTerminal),
true,
withNullAsUndefined(internalOptions?.useShellEnvironment)
withNullAsUndefined(internalOptions?.useShellEnvironment),
withNullAsUndefined(internalOptions?.isSplitTerminal)
);
return terminal.value;
}