diff --git a/src/vs/vscode.proposed.d.ts b/src/vs/vscode.proposed.d.ts index 8f47466ee48..7d689ce3b6f 100644 --- a/src/vs/vscode.proposed.d.ts +++ b/src/vs/vscode.proposed.d.ts @@ -1342,9 +1342,7 @@ declare module 'vscode' { export interface NotebookEditorSelectionChangeEvent { readonly notebookEditor: NotebookEditor; - // @rebornix - // todo@API show NotebookCellRange[] instead - readonly selection?: NotebookCell; + readonly selections: ReadonlyArray } export interface NotebookEditorVisibleRangesChangeEvent { diff --git a/src/vs/workbench/api/common/extHostNotebook.ts b/src/vs/workbench/api/common/extHostNotebook.ts index 59a14474356..0d330af22a8 100644 --- a/src/vs/workbench/api/common/extHostNotebook.ts +++ b/src/vs/workbench/api/common/extHostNotebook.ts @@ -596,10 +596,10 @@ export class ExtHostNotebookController implements ExtHostNotebookShape { if (data.selections) { editor.editor._acceptSelections(data.selections.selections); - this._onDidChangeNotebookEditorSelection.fire({ + this._onDidChangeNotebookEditorSelection.fire(Object.freeze({ notebookEditor: editor.editor.editor, - selection: editor.editor.editor.selection - }); + selections: editor.editor.editor.selections + })); } }