make preload a creation argument, no editor needed when calling asWebviewUri

This commit is contained in:
Johannes Rieken
2021-04-16 11:29:28 +02:00
parent fd7cedae03
commit c074bf897c
2 changed files with 7 additions and 9 deletions

View File

@@ -58,6 +58,7 @@ export class ExtHostNotebookKernels implements ExtHostNotebookKernelsShape {
extensionLocation: extension.extensionLocation,
label: options.label,
supportedLanguages: [],
preloads: options.preloads ? options.preloads.map(extHostTypeConverters.NotebookKernelPreload.from) : []
};
//
@@ -123,11 +124,7 @@ export class ExtHostNotebookKernels implements ExtHostNotebookKernelsShape {
_update();
},
get preloads() {
return data.preloads && data.preloads.map(extHostTypeConverters.NotebookKernelPreload.to);
},
set preloads(value) {
data.preloads = value && value.map(extHostTypeConverters.NotebookKernelPreload.from);
_update();
return data.preloads ? data.preloads.map(extHostTypeConverters.NotebookKernelPreload.to) : [];
},
get executeHandler() {
return _executeHandler;
@@ -162,8 +159,8 @@ export class ExtHostNotebookKernels implements ExtHostNotebookKernelsShape {
postMessage(message, editor) {
return that._proxy.$postMessage(handle, editor && that._extHostNotebook.getIdByEditor(editor), message);
},
asWebviewUri(uri: URI, editor) {
return asWebviewUri(that._initData.environment, that._extHostNotebook.getIdByEditor(editor)!, uri);
asWebviewUri(uri: URI) {
return asWebviewUri(that._initData.environment, data.id, uri);
}
};