From c1cfeed1a7ace2febb8a32144fa98d32c560e4bb Mon Sep 17 00:00:00 2001
From: meganrogge <megrogge@gmail.com>
Date: Mon, 12 Jul 2021 08:42:03 -0700
Subject: [PATCH] fix #128044

---
 src/vs/workbench/api/common/extHostTerminalService.ts | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/vs/workbench/api/common/extHostTerminalService.ts b/src/vs/workbench/api/common/extHostTerminalService.ts
index 21d9cbdedbe..e36e5403ee1 100644
--- a/src/vs/workbench/api/common/extHostTerminalService.ts
+++ b/src/vs/workbench/api/common/extHostTerminalService.ts
@@ -845,9 +845,11 @@ function asTerminalIcon(iconPath?: vscode.Uri | { light: vscode.Uri; dark: vscod
 	if (!iconPath) {
 		return undefined;
 	}
-	if (!('id' in iconPath)) {
+
+	if (typeof iconPath === 'string' || !('id' in iconPath)) {
 		return iconPath;
 	}
+
 	return {
 		id: iconPath.id,
 		color: iconPath.color as ThemeColor