Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-25 02:58:56 +01:00
Code Issues Packages Projects Releases Wiki Activity

Revert "When having details for non modal, show more which shows modal... https://github.com/microsoft/vscode/issues/125750"

Browse Source 
This reverts commit fbe6292824.
This commit is contained in:
Johannes Rieken
2021-06-17 11:20:12 +02:00
parent 4b537c8a0f
commit c24879b45a
2 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/vs/workbench/api/browser/mainThreadMessageService.ts
View File

@@ -35,11 +35,11 @@ export class MainThreadMessageService implements MainThreadMessageServiceShape {
if (options.modal) {
return this._showModalMessage(severity, message, options.detail, commands, options.useCustom);
} else {
return this._showNotificationMessage(severity, message, options.detail, commands, options.extension);
return this._showMessage(severity, message, commands, options.extension);
}
}
private _showNotificationMessage(severity: Severity, message: string, detail: string | undefined, commands: { title: string; isCloseAffordance: boolean; handle: number; }[], extension: IExtensionDescription | undefined): Promise<number | undefined> {
private _showMessage(severity: Severity, message: string, commands: { title: string; isCloseAffordance: boolean; handle: number; }[], extension: IExtensionDescription | undefined): Promise<number | undefined> {
return new Promise<number | undefined>(resolve => {
@@ -66,12 +66,6 @@ export class MainThreadMessageService implements MainThreadMessageServiceShape {
primaryActions.push(new MessageItemAction('_extension_message_handle_' + command.handle, command.title, command.handle));
});
if (detail) {
primaryActions.push(new Action('more', nls.localize('details', "More"), undefined, true, () => {
this._showModalMessage(severity, message, detail, commands, false);
}));
}
let source: string | { label: string, id: string } | undefined;
if (extension) {
source = {