Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-27 12:04:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

Move QuickPick on to an ObjectTree (#207520)

Browse Source 
* Move QuickPick on to an ObjectTree

Enables sticky scroll

* Fix tests

* fix tests take 2

* fix tests by cleaning up disposables

* fix tests again

* `setChildren` less

* test if this is what fixes CI (but local would be broken)

* remove setFocus call since it just sends a random event that we don't need

* Only apply events to quickpickitems not separators

* a comment
This commit is contained in:
Tyler James Leonhardt
2024-03-13 16:45:12 -07:00
committed by GitHub
parent 315ae79d96
commit c349c44f08
10 changed files with 807 additions and 626 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
extensions/vscode-api-tests/src/singlefolder-tests/quickInput.test.ts
View File

@@ -139,9 +139,9 @@ suite('vscode API - quick input', function () {
};
const quickPick = createQuickPick({
events: ['active', 'selection', 'accept', 'active', 'selection', 'active', 'selection', 'accept', 'hide'],
activeItems: [['eins'], [], ['drei']],
selectionItems: [['eins'], [], ['drei']],
events: ['active', 'selection', 'accept', 'active', 'selection', 'accept', 'hide'],
activeItems: [['eins'], ['drei']],
selectionItems: [['eins'], ['drei']],
acceptedItems: {
active: [['eins'], ['drei']],
selection: [['eins'], ['drei']],