Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-04-19 16:18:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix commit character list

Browse Source 
We were modifying the default commit character array, which ended up making it thousands of elements long
This commit is contained in:
Matt Bierner
2024-08-13 14:34:15 -07:00
parent 27dea3ff4b
commit c3fdd34df5
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
extensions/typescript-language-features/src/languageFeatures/completions.ts
View File

@@ -504,9 +504,10 @@ class MyCompletionItem extends vscode.CompletionItem {
private static getCommitCharacters(
context: CompletionContext,
entry: Proto.CompletionEntry,
defaultCommitCharacters: readonly string[] | undefined): string[] | undefined {
defaultCommitCharacters: readonly string[] | undefined,
): string[] | undefined {
// @ts-expect-error until TS 5.6
let commitCharacters = entry.commitCharacters ?? defaultCommitCharacters;
let commitCharacters = (entry.commitCharacters as string[] | undefined) ?? (defaultCommitCharacters ? Array.from(defaultCommitCharacters) : undefined);
if (commitCharacters) {
if (context.enableCallCompletions
&& !context.isNewIdentifierLocation
@@ -781,7 +782,7 @@ class TypeScriptCompletionItemProvider implements vscode.CompletionItemProvider<
const entries = response.body.entries;
const metadata = response.metadata;
// @ts-expect-error until TS 5.6
const defaultCommitCharacters = response.body.defaultCommitCharacters;
const defaultCommitCharacters: readonly string[] | undefined = Object.freeze(response.body.defaultCommitCharacters);
if (response.body.optionalReplacementSpan) {
optionalReplacementRange = typeConverters.Range.fromTextSpan(response.body.optionalReplacementSpan);