Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2025-12-23 19:59:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Write markdown link setting change to correct scope (#159816)

Browse Source 
Fixes #159084

Also fixes the same issue for JS/TS
This commit is contained in:
Matt Bierner
2022-09-01 20:38:41 -07:00
committed by GitHub
parent d9fd208c29
commit c4722f1bb2
3 changed files with 35 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
extensions/typescript-language-features/src/languageFeatures/updatePathsOnRename.ts
View File

@@ -199,7 +199,7 @@ class UpdateImportsOnFileRenameHandler extends Disposable {
config.update(
updateImportsOnFileMoveName,
UpdateImportsOnFileMoveSetting.Always,
vscode.ConfigurationTarget.Global);
this.getConfigTargetScope(config, updateImportsOnFileMoveName));
return true;
}
case Choice.Never:
@@ -208,7 +208,7 @@ class UpdateImportsOnFileRenameHandler extends Disposable {
config.update(
updateImportsOnFileMoveName,
UpdateImportsOnFileMoveSetting.Never,
vscode.ConfigurationTarget.Global);
this.getConfigTargetScope(config, updateImportsOnFileMoveName));
return false;
}
}
@@ -284,6 +284,19 @@ class UpdateImportsOnFileRenameHandler extends Disposable {
paths.push('');
return paths.join('\n');
}
private getConfigTargetScope(config: vscode.WorkspaceConfiguration, settingsName: string): vscode.ConfigurationTarget {
const inspected = config.inspect(settingsName);
if (inspected?.workspaceFolderValue) {
return vscode.ConfigurationTarget.WorkspaceFolder;
}
if (inspected?.workspaceValue) {
return vscode.ConfigurationTarget.Workspace;
}
return vscode.ConfigurationTarget.Global;
}
}
export function register(