From c838b56b6c404ecff40f697b36b686cb44e75d9e Mon Sep 17 00:00:00 2001
From: Michael Lively <milively@microsoft.com>
Date: Thu, 27 Jul 2023 11:26:19 -0700
Subject: [PATCH] notebook sticky line memory-leaks (#189084)

nb memory-leaks
---
 .../browser/viewModel/notebookOutlineProvider.ts       |  3 ++-
 .../browser/viewParts/notebookEditorStickyScroll.ts    | 10 +++++++---
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/src/vs/workbench/contrib/notebook/browser/viewModel/notebookOutlineProvider.ts b/src/vs/workbench/contrib/notebook/browser/viewModel/notebookOutlineProvider.ts
index 5d24c78362b..47971ec803e 100644
--- a/src/vs/workbench/contrib/notebook/browser/viewModel/notebookOutlineProvider.ts
+++ b/src/vs/workbench/contrib/notebook/browser/viewModel/notebookOutlineProvider.ts
@@ -184,7 +184,8 @@ export class NotebookCellOutlineProvider {
 	}
 
 	dispose(): void {
-		// selectionListener.clear();
+		this._entries.length = 0;
+		this._activeEntry = undefined;
 		this._entriesDisposables.dispose();
 		this._dispoables.dispose();
 	}
diff --git a/src/vs/workbench/contrib/notebook/browser/viewParts/notebookEditorStickyScroll.ts b/src/vs/workbench/contrib/notebook/browser/viewParts/notebookEditorStickyScroll.ts
index 2a6f609a237..824835d21d0 100644
--- a/src/vs/workbench/contrib/notebook/browser/viewParts/notebookEditorStickyScroll.ts
+++ b/src/vs/workbench/contrib/notebook/browser/viewParts/notebookEditorStickyScroll.ts
@@ -55,8 +55,7 @@ class NotebookStickyLine extends Disposable {
 		public readonly notebookEditor: INotebookEditor,
 	) {
 		super();
-		this._register(DOM.addDisposableListener(this.element, DOM.EventType.CLICK, (e) => {
-			console.log('click on sticky line');
+		this._register(DOM.addDisposableListener(this.element, DOM.EventType.CLICK, () => {
 			this.focusCell();
 		}));
 	}
@@ -78,7 +77,6 @@ class NotebookStickyLine extends Disposable {
 		}
 		return count;
 	}
-
 }
 
 
@@ -134,6 +132,9 @@ export class NotebookStickyScroll extends Disposable {
 			this.init();
 		} else {
 			this._disposables.clear();
+			this.currentStickyLines.forEach((value) => {
+				value.dispose();
+			});
 			DOM.clearNode(this.domNode);
 			this.updateDisplay();
 		}
@@ -444,6 +445,9 @@ export class NotebookStickyScroll extends Disposable {
 
 	override dispose() {
 		this._disposables.dispose();
+		this.currentStickyLines.forEach((value) => {
+			value.dispose();
+		});
 		super.dispose();
 	}
 }