do not change ids of actions - can break people

This commit is contained in:
isidor
2016-09-23 16:56:45 +02:00
parent e3e7cca3a6
commit c8e7f34ec8
6 changed files with 8 additions and 6 deletions

View File

@@ -54,7 +54,7 @@ class OpenDebugViewletAction extends viewlet.ToggleViewletAction {
}
class OpenDebugPanelAction extends panel.TogglePanelAction {
public static ID = debug.REPL_ID;
public static ID = 'workbench.debug.action.toggleRepl';
public static LABEL = nls.localize('toggleDebugPanel', "Debug Console");
constructor(

View File

@@ -26,6 +26,8 @@ import Tree = require('vs/base/parts/tree/browser/tree');
export class ToggleMarkersPanelAction extends TogglePanelAction {
public static ID = 'workbench.actions.view.problems';
constructor(id: string, label: string,
@IPartService partService: IPartService,
@IPanelService panelService: IPanelService,

View File

@@ -40,7 +40,7 @@ export function registerContributions(): void {
let registry = <IWorkbenchActionRegistry>platform.Registry.as(ActionExtensions.WorkbenchActions);
registry.registerWorkbenchAction(new SyncActionDescriptor(markersPanelActions.ToggleMarkersPanelAction, Constants.MARKERS_PANEL_ID, Messages.MARKERS_PANEL_TOGGLE_LABEL, {
registry.registerWorkbenchAction(new SyncActionDescriptor(markersPanelActions.ToggleMarkersPanelAction, markersPanelActions.ToggleMarkersPanelAction.ID, Messages.MARKERS_PANEL_TOGGLE_LABEL, {
primary: KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.KEY_M
}), 'View: ' + Messages.MARKERS_PANEL_TOGGLE_LABEL, Messages.MARKERS_PANEL_VIEW_CATEGORY);

View File

@@ -15,7 +15,7 @@ import {IPanelService} from 'vs/workbench/services/panel/common/panelService';
export class ToggleOutputAction extends Action {
public static ID = OUTPUT_PANEL_ID;
public static ID = 'workbench.action.output.toggleOutput';
public static LABEL = nls.localize('toggleOutput', "Toggle Output");
constructor(

View File

@@ -8,13 +8,13 @@ import os = require('os');
import { Action, IAction } from 'vs/base/common/actions';
import { EndOfLinePreference } from 'vs/editor/common/editorCommon';
import { ICodeEditorService } from 'vs/editor/common/services/codeEditorService';
import { ITerminalService, TERMINAL_PANEL_ID } from 'vs/workbench/parts/terminal/electron-browser/terminal';
import { ITerminalService } from 'vs/workbench/parts/terminal/electron-browser/terminal';
import { SelectActionItem } from 'vs/base/browser/ui/actionbar/actionbar';
import { TPromise } from 'vs/base/common/winjs.base';
export class ToggleTerminalAction extends Action {
public static ID = TERMINAL_PANEL_ID;
public static ID = 'workbench.action.terminal.toggleTerminal';
public static LABEL = nls.localize('workbench.action.terminal.toggleTerminal', "Toggle Integrated Terminal");
constructor(