From c8fc3e418edc9bee678f2d2fef9a8b7e19e9ca65 Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Sat, 22 Oct 2016 04:40:16 -0700 Subject: [PATCH] Clean up terminal api tests --- extensions/vscode-api-tests/src/window.test.ts | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/extensions/vscode-api-tests/src/window.test.ts b/extensions/vscode-api-tests/src/window.test.ts index 42cdf1a7531..b229fae155f 100644 --- a/extensions/vscode-api-tests/src/window.test.ts +++ b/extensions/vscode-api-tests/src/window.test.ts @@ -319,14 +319,13 @@ suite('window namespace tests', () => { }, 'Terminal.name should be readonly'); }); - test('createTerminal, immediate Terminal.sendText', () => { - var terminal = window.createTerminal(); - // This should not throw an exception - terminal.sendText('echo "foo"'); + test('terminal, sendText immediately after createTerminal should not throw', () => { + const terminal = window.createTerminal(); + assert.doesNotThrow(terminal.sendText.bind(terminal, 'echo "foo"')); }); - test('onDidCloseTerminal, event fires when terminal is disposed', (done) => { - var terminal = window.createTerminal(); + test('terminal, onDidCloseTerminal event fires when terminal is disposed', (done) => { + const terminal = window.createTerminal(); window.onDidCloseTerminal((eventTerminal) => { assert.equal(terminal, eventTerminal); done(); @@ -334,10 +333,14 @@ suite('window namespace tests', () => { terminal.dispose(); }); - test('createTerminal, immediate Terminal.processId', (done) => { + test('terminal, processId immediately after createTerminal should fetch the pid', (done) => { window.createTerminal().processId.then(id => { assert.ok(id > 0); done(); }); }); + + test('terminal, name should set terminal.name', () => { + assert.equal(window.createTerminal('foo').name, 'foo'); + }); });