Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-03 23:06:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixes #2930: Bad argument

Browse Source
This commit is contained in:
Dirk Baeumer
2016-02-19 12:27:08 +01:00
parent b1d162ca87
commit c93167fec5
1 changed files with 39 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

70
extensions/php/src/features/validationProvider.ts
View File

@@ -184,41 +184,49 @@ export default class PHPValidationProvider {
} else {
args = PHPValidationProvider.BufferArgs;
}
let childProcess = cp.spawn(executable, args, options);
childProcess.on('error', (error: Error) => {
if (this.executableNotFound) {
resolve();
return;
}
let message: string = null;
if ((<any>error).code === 'ENOENT') {
message = `Cannot validate the php file. The php program was not found. Use the 'php.validate.executablePath' setting to configure the location of 'php'`;
} else {
message = error.message ? error.message : `Failed to run php using path: ${executable}. Reason is unknown.`;
}
vscode.window.showInformationMessage(message);
this.executableNotFound = true;
resolve();
});
if (childProcess.pid) {
if (this.trigger === RunTrigger.onType) {
childProcess.stdin.write(textDocument.getText());
childProcess.stdin.end();
}
childProcess.stdout.on('data', (data: Buffer) => {
decoder.write(data).forEach(processLine);
});
childProcess.stdout.on('end', () => {
let line = decoder.end();
if (line) {
processLine(line);
try {
let childProcess = cp.spawn(executable, args, options);
childProcess.on('error', (error: Error) => {
if (this.executableNotFound) {
resolve();
return;
}
this.diagnosticCollection.set(textDocument.uri, diagnostics);
this.showError(error, executable);
this.executableNotFound = true;
resolve();
});
} else {
resolve();
if (childProcess.pid) {
if (this.trigger === RunTrigger.onType) {
childProcess.stdin.write(textDocument.getText());
childProcess.stdin.end();
}
childProcess.stdout.on('data', (data: Buffer) => {
decoder.write(data).forEach(processLine);
});
childProcess.stdout.on('end', () => {
let line = decoder.end();
if (line) {
processLine(line);
}
this.diagnosticCollection.set(textDocument.uri, diagnostics);
resolve();
});
} else {
resolve();
}
} catch (error) {
this.showError(error, executable);
}
});
}
private showError(error: any, executable: string): void {
let message: string = null;
if (error.code === 'ENOENT') {
message = `Cannot validate the php file. The php program was not found. Use the 'php.validate.executablePath' setting to configure the location of 'php'`;
} else {
message = error.message ? error.message : `Failed to run php using path: ${executable}. Reason is unknown.`;
}
vscode.window.showInformationMessage(message);
}
}